Hi

I would propose to log whether or not OSGi was detected. As standalone
is a bit misleading/confusing. There are many other deployments
options and what if you run in the cloud, J2ee, tomcat etc.

What about just logging like:

            LOG.info("OSGi environment detected.");

          LOG.info("OSGi environment not detected.");



On Wed, Jul 14, 2010 at 4:04 AM,  <ningji...@apache.org> wrote:
> Author: ningjiang
> Date: Wed Jul 14 02:04:03 2010
> New Revision: 963924
>
> URL: http://svn.apache.org/viewvc?rev=963924&view=rev
> Log:
> CAMEL-2941 changed the osgi detection log
>
> Modified:
>    
> camel/trunk/components/camel-spring/src/main/java/org/apache/camel/spring/handler/CamelNamespaceHandler.java
>
> Modified: 
> camel/trunk/components/camel-spring/src/main/java/org/apache/camel/spring/handler/CamelNamespaceHandler.java
> URL: 
> http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/main/java/org/apache/camel/spring/handler/CamelNamespaceHandler.java?rev=963924&r1=963923&r2=963924&view=diff
> ==============================================================================
> --- 
> camel/trunk/components/camel-spring/src/main/java/org/apache/camel/spring/handler/CamelNamespaceHandler.java
>  (original)
> +++ 
> camel/trunk/components/camel-spring/src/main/java/org/apache/camel/spring/handler/CamelNamespaceHandler.java
>  Wed Jul 14 02:04:03 2010
> @@ -126,9 +126,9 @@ public class CamelNamespaceHandler exten
>             LOG.trace("Cannot find class so assuming not running in OSGi 
> container: " + t.getMessage());
>         }
>         if (osgi) {
> -            LOG.info("camel-osgi.jar/camel-spring-osgi.jar detected in 
> classpath");
> +            LOG.info("Found the OSGi environment, deloying the camel context 
> into OSGi container");
>         } else {
> -            LOG.info("camel-osgi.jar/camel-spring-osgi.jar not detected in 
> classpath");
> +            LOG.info("Cannot find the OSGi environment, deploying the camel 
> context into stand alone JVM");
>         }
>         if (LOG.isDebugEnabled()) {
>             LOG.debug("Using " + cl.getCanonicalName() + " as 
> CamelContextBeanDefinitionParser");
>
>
>



-- 
Claus Ibsen
Apache Camel Committer

Author of Camel in Action: http://www.manning.com/ibsen/
Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus

Reply via email to