[
https://issues.apache.org/activemq/browse/CAMEL-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60821#action_60821
]
Claus Ibsen commented on CAMEL-2779:
------------------------------------
Looks good a couple of comments
- You may have to close streams after usage. You got a bit of input stream
which most often need to be closed after usage
- Why does the component deps on camel-spring? Is spring really needed for
Shiro? If not remove this dep.
- I think there is a bit too much DEBUG logging. Some of them can be turned
into TRACE.
- In authenticateUser why do you wrap the thrown exceptions? Isn't it possible
to throw the exceptions as is? eg just add throws Exception to the method
signature? I assume Shiro contains detailed information why the exception was
thrown.
- The AuthenticationPolicy need to support async routing engine. This is
something I can help with when we got the other sorted out. (The same most
likely applies for camel-spring-security)
> Security - Allow to use Apache Shiro as security framework as well
> ------------------------------------------------------------------
>
> Key: CAMEL-2779
> URL: https://issues.apache.org/activemq/browse/CAMEL-2779
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-shiro-20100714.zip, camel-shiro.diff
>
>
> Looks like Apache Shiro could be a good security framework
> http://incubator.apache.org/shiro/index.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
