[ https://issues.apache.org/activemq/browse/CAMEL-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61147#action_61147 ]
Willem Jiang commented on CAMEL-3033: ------------------------------------- Hi Savas, I went through your patch, just few comments here. If you take a look at CXF FaultOutInterceptor and WebFaultOutInterceptor, you will find CXF already did that kind of thing for you. Such as setting the fault message with fault cause message , and building up the fault detail, all you need to do is make sure that your fault is thrown rightly from CxfConsumer. For the test part , you don't change anything the verification part of CXF test code, which means you patch didn't improve any thing. Can you write a small test case to demonstrate that current camel-cxf can't handle the fault rightly? > @WebFault interceptor to map exceptions to faults > ------------------------------------------------- > > Key: CAMEL-3033 > URL: https://issues.apache.org/activemq/browse/CAMEL-3033 > Project: Apache Camel > Issue Type: New Feature > Components: camel-core > Reporter: Claus Ibsen > Priority: Minor > Fix For: Future > > Attachments: > camel-3033_webfault_annotated_exception_to_soapfault.patch > > > Like the {{HandleFaultInterceptor}} which turns fault -> exception, we should > offer the reverse. > The @WebFault is a standard annotation. The interceptor should then > introspect the thrown exception and see if its annotated with @WebFault. If > so it should turn the exception into a fault message. > See nabble > http://camel.465427.n5.nabble.com/CXF-consumer-fault-handling-tp2264078p2264078.html > It should be possible to include in camel-core as annotations jars is > optional. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.