Hi
Yay sounds good. I am all good.
On Fri, Oct 15, 2010 at 4:18 PM, Hadrian Zbarcea <hzbar...@gmail.com> wrote:
> From my point of view all the issues that needed fixing for the 2.5.0 release
> are resolved. I am planning on building the release candidate this afternoon.
> If there is any issue that you absolutely must push into the 2.5.0 release
> now is the time to shout.
>
> Cheers,
> Hadrian
>
>
> On Oct 14, 2010, at 8:28 PM, Willem Jiang wrote:
>
>> +1 for the option 3.
>>
>> Willem
>>
>> On 10/15/10 12:17 AM, Daniel Kulp wrote:
>>> On Thursday 14 October 2010 9:28:06 am Willem Jiang wrote:
>>>> Hi Hadrian,
>>>>
>>>> I saw the issue after import the project into Eclipse.
>>>
>>> I've been trying to dig into this a bit.
>>>
>>> From what I can tell, the ONLY reason the pom is doing this is to get the
>>> sources for those classes into the sources jar. The bundle plugin already
>>> puts the .class files for those into the real jar so it's not needed for
>>> compiling or anything. Its JUST for the sources jar.
>>>
>>> Thus, there are three coarses of action I can see:
>>>
>>> 1) Ignore it and let the eclipse projects fail. I don't like this.
>>>
>>> 2) Remove this config from the pom. The source jars just would not have the
>>> sources for these classes. Not sure if thats a big deal.
>>>
>>> 3) Change it to use antrun to add those extra sources in the package phase.
>>> Patch for camel-spring below to look at.
>>>
>>> Thoughts?
>>>
>>> Dan
>>>
>>>
>>>
>>>
>>> diff --git a/components/camel-spring/pom.xml
>>> b/components/camel-spring/pom.xml
>>> index b6404a2..bc944cb 100644
>>> --- a/components/camel-spring/pom.xml
>>> +++ b/components/camel-spring/pom.xml
>>> @@ -275,6 +275,11 @@
>>> <echo>Deleting unwanted resources from the test-jar</echo>
>>> <delete file="${project.build.directory}/test-
>>> classes/log4j.properties" verbose="true" />
>>> <delete file="${project.build.directory}/test-classes/META-
>>> INF/spring/*" verbose="true" />
>>> +
>>> +<jar destfile="${project.build.directory}/camel-spring-2.5-
>>> SNAPSHOT-sources.jar" update="true">
>>> +<fileset dir="${basedir}/../camel-core-osgi/src/main/java"
>>> includes="**/*"/>
>>> +<fileset dir="${basedir}/../camel-core-xml/src/main/java"
>>> includes="**/*"/>
>>> +</jar>
>>> </tasks>
>>> </configuration>
>>> <goals>
>>> @@ -290,19 +295,6 @@
>>> <artifactId>build-helper-maven-plugin</artifactId>
>>> <executions>
>>> <execution>
>>> -<id>add-source</id>
>>> -<phase>generate-sources</phase>
>>> -<goals>
>>> -<goal>add-source</goal>
>>> -</goals>
>>> -<configuration>
>>> -<sources>
>>> -<source>${basedir}/../camel-core-osgi/src/main/java</source>
>>> -<source>${basedir}/../camel-core-xml/src/main/java</source>
>>> -</sources>
>>> -</configuration>
>>> -</execution>
>>> -<execution>
>>> <id>attach-artifacts</id>
>>> <phase>package</phase>
>>> <goals>
>>>
>>>
>>>
>>>>
>>>> On 10/14/10 8:01 PM, Hadrian Zbarcea wrote:
>>>>> Thanks Dan.
>>>>>
>>>>> Willem, try loading the generated .projects in eclipse, you'll know what
>>>>> I mean. Dan, it's because of the osgi support that moved between
>>>>> components.
>>>>>
>>>>> Hadrian
>>>>>
>>>>> On Oct 14, 2010, at 7:43 AM, Daniel Kulp wrote:
>>>>>> Just because it runs doesn't mean it works. The generated projects
>>>>>> cannot be imported into Eclipse. You should not be pointing to src
>>>>>> dirs outside the maven project. That breaks all kinds of things,
>>>>>> eclipse being one of them.
>>>>>>
>>>>>> There are a couple solutions, but I have to ask why it's even doing
>>>>>> that? Why can't the two affected modules just depend on the others?
>>>>>> Why do they need to have to duplicate the classes in them?
>>>>>>
>>>>>> Dan
>>>>>>
>>>>>> On Thursday 14 October 2010 2:07:26 am Willem Jiang wrote:
>>>>>>> I just run the mvn eclipse:eclipse on the latest chuck code, every
>>>>>>> thing looks good.
>>>>>>>
>>>>>>> Here is my system information.
>>>>>>>
>>>>>>> localhost:trunk jiangning$ mvn -version
>>>>>>> Apache Maven 2.2.1 (r801777; 2009-08-07 03:16:01+0800)
>>>>>>> Java version: 1.6.0_20
>>>>>>> Java home:
>>>>>>> /System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home
>>>>>>> Default locale: en_US, platform encoding: MacRoman
>>>>>>> OS name: "mac os x" version: "10.6.4" arch: "x86_64" Family: "mac"
>>>>>>>
>>>>>>> On 10/14/10 1:52 PM, Claus Ibsen wrote:
>>>>>>>> On Thu, Oct 14, 2010 at 7:24 AM, Hadrian Zbarcea<hzbar...@gmail.com>
>>>>>>
>>>>>> wrote:
>>>>>>>>> Willem, it works fine now. The only issue we have now is with the
>>>>>>>>> eclipse goal not working properly due to the
>>>>>>>>> build-helper-maven-plugin in camel-spring and camel-blueprint. It's
>>>>>>>>> not really a blocker, but it'd avoid releasing with this broken if
>>>>>>>>> possible. I hope we could resolve this tomorrow. It's the last thing
>>>>>>>>> I know of that should be done for the 2.5.0 release.
>>>>>>>>
>>>>>>>> I think this is because of the Maven 3 changes. I did a full mvn
>>>>>>>> eclipse:eclipse for the entire project when we upgraded all the
>>>>>>>> versions in the pom.
>>>>>>>> And it ran 100%.
>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>> Hadrian
>>>>>>>>>
>>>>>>>>> On Oct 14, 2010, at 12:58 AM, Willem Jiang wrote:
>>>>>>>>>> Hi hadrian,
>>>>>>>>>>
>>>>>>>>>> What's the problem of the camel-jetty build?
>>>>>>>>>> Are they new build failures?
>>>>>>>>>>
>>>>>>>>>> On 10/14/10 11:30 AM, Hadrian Zbarcea wrote:
>>>>>>>>>>> Still a few errors to sort out. I got a couple of failures in
>>>>>>>>>>> jetty, the eclipse goal is not working properly either yet in
>>>>>>>>>>> spring and blueprint. Hadrian
>>>>>>>>>>>
>>>>>>>>>>> On Oct 13, 2010, at 5:56 PM, Claus Ibsen wrote:
>>>>>>>>>>>> Hadrian, how is the 2.5 release going?
>>>>>>>>>>>>
>>>>>>>>>>>> On Tue, Oct 12, 2010 at 9:53 PM, Henryk Konsek<hekon...@gmail.com>
>>>>>>
>>>>>> wrote:
>>>>>>>>>>>>> When you release camel-apache, I'll release camel-extra 2.5 .
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Tue, Oct 12, 2010 at 9:24 PM, Claus
>>>>>>>>>>>>> Ibsen<claus.ib...@gmail.com>
>>>>>>
>>>>>> wrote:
>>>>>>>>>>>>>> Okay all is set and we are ready for the 2.5 release.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hadrian take it away.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Tue, Oct 12, 2010 at 4:50 PM, Claus
>>>>>>>>>>>>>> Ibsen<claus.ib...@gmail.com>
>>>>>>
>>>>>> wrote:
>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Last minute ticket which James Strachan would love to get in
>>>>>>>>>>>>>>> https://issues.apache.org/activemq/browse/CAMEL-3222
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I am running full test now with the fixes. Before committing to
>>>>>>>>>>>>>>> trunk. I will let you know when its committed so we can start
>>>>>>>>>>>>>>> the cut.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Tue, Oct 12, 2010 at 3:22 PM, Hadrian
>>>>>>
>>>>>> Zbarcea<hzbar...@gmail.com> wrote:
>>>>>>>>>>>>>>>> I did some sanity checks in the past days, and as I mentioned
>>>>>>>>>>>>>>>> earlier on the #camel channel, I already started the builds
>>>>>>>>>>>>>>>> for the 2.5.0 release. I only encountered an intermittent
>>>>>>>>>>>>>>>> problem with camel-ftp in the past days that may cause some
>>>>>>>>>>>>>>>> problem (i hope not), other than that we should be able to
>>>>>>>>>>>>>>>> start the vote today.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Cheers
>>>>>>>>>>>>>>>> Hadrian
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Oct 12, 2010, at 12:24 AM, Claus Ibsen wrote:
>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> We have upgraded to Scalate 1.3 and CXF 2.2.11. We should be
>>>>>>>>>>>>>>>>> all set in terms of dependencies.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hadrian do you have time to do the 2.5 release?
>>>>>>>>>>>>>>>>> It would be great to get it out really soon. Its been 3
>>>>>>>>>>>>>>>>> months since the last release and we have a lot of tickets
>>>>>>>>>>>>>>>>> resolved in this release.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>> Claus Ibsen
>>>>>>>>>>>>>>>>> Apache Camel Committer
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Author of Camel in Action: http://www.manning.com/ibsen/
>>>>>>>>>>>>>>>>> Open Source Integration: http://fusesource.com
>>>>>>>>>>>>>>>>> Blog: http://davsclaus.blogspot.com/
>>>>>>>>>>>>>>>>> Twitter: http://twitter.com/davsclaus
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Claus Ibsen
>>>>>>>>>>>>>>> Apache Camel Committer
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Author of Camel in Action: http://www.manning.com/ibsen/
>>>>>>>>>>>>>>> Open Source Integration: http://fusesource.com
>>>>>>>>>>>>>>> Blog: http://davsclaus.blogspot.com/
>>>>>>>>>>>>>>> Twitter: http://twitter.com/davsclaus
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Claus Ibsen
>>>>>>>>>>>>>> Apache Camel Committer
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Author of Camel in Action: http://www.manning.com/ibsen/
>>>>>>>>>>>>>> Open Source Integration: http://fusesource.com
>>>>>>>>>>>>>> Blog: http://davsclaus.blogspot.com/
>>>>>>>>>>>>>> Twitter: http://twitter.com/davsclaus
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Henryk Konsek
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Claus Ibsen
>>>>>>>>>>>> Apache Camel Committer
>>>>>>>>>>>>
>>>>>>>>>>>> Author of Camel in Action: http://www.manning.com/ibsen/
>>>>>>>>>>>> Open Source Integration: http://fusesource.com
>>>>>>>>>>>> Blog: http://davsclaus.blogspot.com/
>>>>>>>>>>>> Twitter: http://twitter.com/davsclaus
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Willem
>>>>>>>>>> ----------------------------------
>>>>>>>>>> Open Source Integration: http://www.fusesource.com
>>>>>>>>>> Blog: http://willemjiang.blogspot.com (English)
>>>>>>>>>>
>>>>>>>>>> http://jnn.javaeye.com (Chinese)
>>>>>>>>>>
>>>>>>>>>> Twitter: http://twitter.com/willemjiang
>>>>>>
>>>>>> --
>>>>>> Daniel Kulp
>>>>>> dk...@apache.org
>>>>>> http://dankulp.com/blog
>>>
>>
>>
>> --
>> Willem
>> ----------------------------------
>> Open Source Integration: http://www.fusesource.com
>> Blog: http://willemjiang.blogspot.com (English)
>> http://jnn.javaeye.com (Chinese)
>> Twitter: http://twitter.com/willemjiang
>
>
--
Claus Ibsen
Apache Camel Committer
Author of Camel in Action: http://www.manning.com/ibsen/
Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus
