On 2/1/11 2:16 AM, Claus Ibsen wrote:
Hi
I have now committed the "grunt work" of the slf4j migration.
Tomorrow I will migrate the remaining camel components, examples and the likes.
You should now be able to commit major stuff to camel-core or the likes.
You are welcome to run tests on your system to see if the migrated
caused any side effect.
Although I ran a complete full test before committing.
There is 1 unit test in camel-cxf which fails, but I think thats
because of some recent commit in camel-cxf code.
So willem can you take a look at this when you read this?
I just reproduced the error and will commit a fix shortly.
On Mon, Jan 31, 2011 at 6:42 PM, Jean-Baptiste Onofré<j...@nanthrax.net> wrote:
Yeah:
Karaf 2.1.x uses PAX logging 1.5.x and SLF4J 1.5.8.
Karaf 2.2.x uses PAX logging 1.6.0 (that Guillaume and I have released last
week), PAX logging 1.6.0 supports SLF4J 1.6.1.
Regards
JB
On 01/31/2011 05:25 PM, Claus Ibsen wrote:
On Mon, Jan 31, 2011 at 5:14 PM, Guillaume Nodet<gno...@gmail.com> wrote:
Not sure what the issue is, but pax-logging 1.5.x only supports slf4j
<= 1.5.11, so you need to make sure the range of the package uses is
large enough to support existing versions. I'd recommend using
1.5.11 for the slfaj-api and not 1.6.x, unless there are strong
requirements to do so.
Ah yeah good point, I was using 1.6.1. Will try with 1.5.11 for now.
And nuking my local maven repo so it's all freshly downloaded.
I think Jean said pax logging 1.6.0 would support slf4j 1.6.x?
On Mon, Jan 31, 2011 at 16:54, Claus Ibsen<claus.ib...@gmail.com> wrote:
Hi
Okay seems ready for one of the first commits for the migration.
There is an issue with OSGi blueprint, which I will have to revisit.
That OSGi stuff can as usual be a bit tricky to decipher wtf is wrong.
On Mon, Jan 31, 2011 at 3:37 PM, Claus Ibsen<claus.ib...@gmail.com>
wrote:
On Mon, Jan 31, 2011 at 3:10 PM, Hadrian Zbarcea<hzbar...@gmail.com>
wrote:
Claus, if you do it incrementally, and commit only one major component
at a time (the small ones could go together) it will be less painful for you
and others.
Many thanks for the heads up.
Yeah I will try that. Currently I have 200 changes in camel-core and
about 160 in all the others.
Those are just the first migration effort to have a complete build and
test that works.
I may have to break this into 2 commits (1 = core, 2 = other) to not
have one giant commit.
The remainder work is then easy as its just to run the migrator on all
the camel components, examples and so forth.
And to update the pom.xml file so slf4j-log4j bridge is included.
Hadrian
On Jan 31, 2011, at 7:51 AM, Claus Ibsen wrote:
Hi
I am migrating from commons-logging to slf4j which means alot of
files
will be touched by switching the logger.
https://issues.apache.org/jira/browse/CAMEL-3605?focusedCommentId=12988746#comment-12988746
There is a migrating tool to do this, so that part is easy
http://www.slf4j.org/migrator.html
However a few components need to have adjusted pom.xml file and a few
other changes.
I have currently migrated what's minimum required, which is
camel-core, camel-spring, camel-blueprint and some components which
was dependent on stuff from camel-core which have changed slightly.
I am currently running full unit test to ensure all code compiles and
tests successfully before committing any changes.
Any regular or small commits is okay to commit to Apache trunk.
But if you do a lot of refactoring then could you wait a bit, until
the slf4j migrating has been completed.
Its just easier as I will have to do multiple commits to get it fully
migrated.
--
Claus Ibsen
-----------------
FuseSource
Email: cib...@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
--
Claus Ibsen
-----------------
FuseSource
Email: cib...@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
--
Claus Ibsen
-----------------
FuseSource
Email: cib...@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
--
Jean-Baptiste Onofré
---------------------------------
HomePage
http://www.nanthrax.net
---------------------------------
Contacts
jbono...@apache.org
j...@nanthrax.net
---------------------------------
OpenSource
BuildProcess/AutoDeploy
http://buildprocess.sourceforge.net
Apache ServiceMix
http://servicemix.apache.org
-----------------------------------
PGP : 17D4F086
--
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.javaeye.com (Chinese)
Twitter: willemjiang
