[
https://issues.apache.org/jira/browse/CAMEL-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003846#comment-13003846
]
Claus Ibsen commented on CAMEL-3549:
------------------------------------
In this method
public void register(CamelServlet provider, Map properties)
In DefaultHttpRegistry you do some instanceof check. But the parameter is the
same type, so the instanceof check will always be true. Maybe you intended that
the parameter should be javax.servlet.Servlet type instead?
If not then the instanceof check can be removed.
> It should be possible to configure the CamelHttpTransportServlet using the
> spring ContextLoaderListener
> -------------------------------------------------------------------------------------------------------
>
> Key: CAMEL-3549
> URL: https://issues.apache.org/jira/browse/CAMEL-3549
> Project: Camel
> Issue Type: Improvement
> Components: camel-servlet
> Affects Versions: 2.5.0
> Reporter: Christian Schneider
> Assignee: Christian Schneider
> Fix For: 2.7.0
>
> Attachments: camel-servlet-3549.patch
>
>
> The spring security example uses two different spring contexts.
> The first is pulled up using the spring ContextLoaderListener. It is used to
> hook spring security into a filter.
> The second is pulled up by the CamelHttpTransportServlet. There is the main
> configuration includeing the camel context.
> I think this is quite ugly and makes things more complicated than they need
> to be. Especially if you also need the camel context outside the camel
> servlet.
> So I propose to change the code of the Camel Servlet component to simply use
> the spring context from the ContextLoaderListener. I can try to do the change
> myself but would be happy for any comments why this was designed so and where
> I have to be careful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
