[
https://issues.apache.org/jira/browse/CAMEL-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004977#comment-13004977
]
Claus Ibsen commented on CAMEL-3481:
------------------------------------
Aaron I looked at the patch and it looks good. Just a few minor comments
- checkstyle
- you should prefer to use try .. finally when changing the ClassLoader
About checkstyle, you can see more here
http://camel.apache.org/building.html
We prefer the code to pass the checkstyle before committing. Especially for the
core and most used components.
> camel-script doesn't work in OSGi
> ---------------------------------
>
> Key: CAMEL-3481
> URL: https://issues.apache.org/jira/browse/CAMEL-3481
> Project: Camel
> Issue Type: Improvement
> Components: camel-script
> Affects Versions: 2.5.0
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Fix For: 2.8.0
>
> Attachments: camel-core.patch, camel-script.patch
>
>
> In an OSGi environment, the ScriptEngineManager that ScriptBuilder uses can't
> find any scripting engines except the ones packaged in the JDK (Rhino, maybe
> AppleScript, etc.). It's possible that setting a better ClassLoader would
> work, or perhaps using a singleton ScriptEngineManager and setting up the
> scripting engines in an OSGi Activator instead of relying on the META-INF
> lookup every time a script is invoked.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
