[
https://issues.apache.org/jira/browse/CAMEL-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023648#comment-13023648
]
Claus Ibsen commented on CAMEL-3892:
------------------------------------
Fernando can you ZIP the camel-freemarker component and attach that file?
We cant accept your current patch as is, as the diff is to extreme. Eg you
delete all existing files, and add new files.
A patch should only diff the changes, and respect the existing code format /
layout and only alter the code needed to be changed.
So if you have ZIP of the source, I can better grab the pieces we need.
> Refresh of the FreeMarker Component
> -----------------------------------
>
> Key: CAMEL-3892
> URL: https://issues.apache.org/jira/browse/CAMEL-3892
> Project: Camel
> Issue Type: Improvement
> Environment: All Camel environments.
> Reporter: Fernando Ribeiro
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: freemarker.patch
>
>
> I've made a number of small changes to the FreeMarker component:
> - General re-format
> - Added constants for the "encoding" and "contentCache" parameters
> - Removed the unused FREEMARKER_RESOURCE constant
> - Removed the unnecessary "FREEMARKER_" prefix of the FREEMARKER_RESOURCE_URI
> and FREEMARKER_TEMPLATE constants
> - Removed the unnecessary getExchangePattern method
> - Replaced the NoCacheStorage class by a call to a constructor of the
> Template class, that doesn't use any cache
> - Added a default value for the "encoding" parameter (the platform's default)
> - Added a specific exception class to support global exception handlers
> - Renamed all classes from Free*m*arker (wrong) to Free*M*arker
> - Renamed properties from CamelFree*m*arkerResourceUri (wrong) to
> CamelFree*M*arkerResourceUri and CamelFree*m*arkerTemplate to
> CamelFree*M*arker
> - Implemented isDebugEnabled by log.debug, as suggested in CAMEL-3759
> - Improved log messages
> All tests run successfully.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
