[
https://issues.apache.org/jira/browse/CAMEL-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044044#comment-13044044
]
Hadrian Zbarcea commented on CAMEL-4047:
----------------------------------------
More I think about it, more my head spins... I agree 2) would completely solve
the problem, but it is the right solution?
We cannot use the jre version of the ScriptEngineFactory in an OSGi deployment,
that much is clear. Both 1) and 2) do not have *any* impact on non-OSGi
deployments, so we're good there.
Assumption (*): There is a fair percentage of deployments that do *not*
need/use a script engine (say x%).
Solution 2) brings the extra feature dependency for the camel-core on all
*osgi* deployments. If x is relatively small e.g. x <= 20, I don't think it's a
big problem, especially given the meager 32k the extra bundle is bringing.
If x is larger, say x >= 80, would it make sense to make the dependency
optional? Of course we then have the problem Dan explained. We can get
activation to fail for things like camel-bean-validator if camel-core was using
the jre version of the ScriptEngine. 3rd party component writers would have to
be aware of that too.
I don't know it may be overkill for just the 32k... On the plus side, we should
be able to reach a consensus quickly on this though.
> javax.script dependency in camel-core
> -------------------------------------
>
> Key: CAMEL-4047
> URL: https://issues.apache.org/jira/browse/CAMEL-4047
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.8.0
> Reporter: Daniel Kulp
>
> The OSGi imports for camel-core ends up with a non-optional dependency on
> javax.script due to it being used in the Activator. However, the karaf
> feature for camel-core doesn't have a dependency on
> org.apache.servicemix.specs.scripting-api-1.0 .
> One of two things should be done:
> 1) mark javax.script as optional. This MAY require some updates to the
> Activator to work when it's not available.
> 2) Update the karaf features file to add:
> {code:xml}
> <bundle
> dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.scripting-api-1.0/${servicemix-specs-version}</bundle>
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
