On Friday, September 02, 2011 3:06:28 AM [email protected] wrote:
> Author: hadrian
> Date: Fri Sep 2 03:06:28 2011
> New Revision: 1164338
>
> URL: http://svn.apache.org/viewvc?rev=1164338&view=rev
> Log:
> More URI encoding fixes
...........
> camel/trunk/components/camel-gae/src/test/java/org/apache/camel/component/g
> ae/http/GHttpBindingTest.java (original) +++
> camel/trunk/components/camel-gae/src/test/java/org/apache/camel/component/g
> ae/http/GHttpBindingTest.java Fri Sep 2 03:06:28 2011 @@ -103,7 +103,7 @@
> public class GHttpBindingTest {
> assertEquals("http://custom.org:8080/path?a=b";,
> binding.getRequestUrl(endpoint, exchange).toString()); }
>
> - @Test
> + // FIXME: URI encoding @Test
> public void testGetRequestUrlEncoding() throws Exception {
> GHttpEndpoint endpoint =
> createEndpoint("ghttp://somewhere.com:9090/path?bridgeEndpoint=false&a=b
> c"); assertEquals("http://somewhere.com:9090/path?a=b+c";,
> binding.getRequestUrl(endpoint, exchange).toString());
I would suggest using an @Ignore("FIXME: URI encoding") or similar for things
like this in the future. It at least shows up in the test reports that a
test was written, but not run. I hate it when I'm looking through code
and see tests that have been completely commented out. The @Ignore at least
makes finding them later easier.
--
Daniel Kulp
[email protected]
http://dankulp.com/blog
Talend - http://www.talend.com
