[ 
https://issues.apache.org/jira/browse/CAMEL-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144641#comment-13144641
 ] 

Claus Ibsen commented on CAMEL-4618:
------------------------------------

Adam good start. There is also a UnmarshalDefinition in camel-core.

And I think there is another place in the model in camel-core you may need to 
add it. For example check where CryptoDataFormat is used in camel-core.

The attributes in the model classes should not use simple types by object 
types, eg boolean -> Boolean. And they should not have a default value, as we 
do not want default values to be emitted in XML when marshalling routes to XML. 
So boolean foo = true. Should just be Boolean foo. And then in the java code 
you would know that if its == null then its the default value.

Also I think each attribute should have a @XmlAttribute annotation
                
> Add support for PGP data format in Java and XML DSLs
> ----------------------------------------------------
>
>                 Key: CAMEL-4618
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4618
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.9.0
>            Reporter: Claus Ibsen
>             Fix For: 2.10
>
>         Attachments: pgp-camel-core.patch, pgpdataformatv2.patch
>
>
> The new PGP data format from CAMEL-4549
> requires to create it from Java code.
> We should add some syntax sugar and have it in the DSL directly like the 
> other data formats.
> We may also want to look into how to configure a public and private key file, 
> and have it load the PGPPublicKey and PGPPrivateKey for you automatic.
> Instead of using the PGPDataFormatUtil class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to