On 20 June 2012 15:53, Hadrian Zbarcea <hzbar...@gmail.com> wrote: > Bilgin, commit away :). >
ok, it is in. btw I was wrong: enableHangupSupport is used only for graceful shutdown. My application wasn't running continuously because I used the duration option, which shuts down Camel after the duration ends Bilgin > > There is no set rule, but the preference is obviously to do it right away > and the original committer to do the backmerge as well (he should be the > one who knows best). Another advantage is that you get more time to test > the backport if you do it earlier. We're close to releasing 2.9.3 so this > is good timing. > > Thanks again, > Hadrian > > > On 06/20/2012 10:48 AM, Bilgin Ibryam wrote: > >> Hadrian, I will do the change now on trunk (I haven't used my commit right >> that much so far ;) >> >> I got a question though: when do you usually backport the changes from >> trunk to branches: as soon as the commit to trunk, or later - when the >> branch is about to be released? >> >> Bilgin >> >> PS: I've seen >> http://camel.apache.org/**merging-commits-from-trunk-to-** >> fixes-branch.html<http://camel.apache.org/merging-commits-from-trunk-to-fixes-branch.html> >> >> On 20 June 2012 15:34, Hadrian Zbarcea<hzbar...@gmail.com> wrote: >> >> Bilgin, you are correct, it should. Would you have some time to work on a >>> patch? >>> >>> Thanks, >>> Hadrian >>> >>> >>> On 06/20/2012 09:20 AM, Bilgin Ibryam wrote: >>> >>> While I was using camel-guice component, I realized that Main class >>>> (used >>>> to run Camel from GuiceCamelContext) is actually not using >>>> enableHangupSupport and as a result the app is shut down quickly. The >>>> other >>>> Main class implementations in org.apache.camel.main and >>>> org.apache.camel.spring packages use enableHangupSupport. >>>> I think the camel-guice Main should have the same behaviour, WDYT? >>>> >>>> Bilgin >>>> >>>> >>>> >>
