Hi Christian,

This change breaks some unit tests of camel-core, can you have a look at them ?

BTW, 
wrap[org.apache.camel.processor.DefaultErrorHandlerOnExceptionTraceTest$MyProcessor@301a69c]
  is really a good trace lab for us to use.

Failed tests:  
testOk(org.apache.camel.processor.DefaultErrorHandlerOnExceptionTraceTest): 
expected:<[ref:myProcessor]> but 
was:<[wrap[org.apache.camel.processor.DefaultErrorHandlerOnExceptionTraceTest$MyProcessor@301a69c]]>
testWithError(org.apache.camel.processor.DefaultErrorHandlerOnExceptionTraceTest):
 expected:<[ref:myProcessor]> but 
was:<[wrap[org.apache.camel.processor.DefaultErrorHandlerOnExceptionTraceTest$MyProcessor@10042865]]>
testSynchronizeComplete(org.apache.camel.processor.OnCompletionGlobalTraceTest):
 expected:<[ref:myProcessor]> but 
was:<[wrap[org.apache.camel.processor.OnCompletionGlobalTraceTest$MyProcessor@4f4c55e7]]>
testSynchronizeFailure(org.apache.camel.processor.OnCompletionGlobalTraceTest): 
expected:<[ref:myProcessor]> but 
was:<[wrap[org.apache.camel.processor.OnCompletionGlobalTraceTest$MyProcessor@256949fd]]>





--  
Willem Jiang

Red Hat, Inc.
FuseSource is now part of Red Hat
Web: http://www.fusesource.com | http://www.redhat.com
Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) 
(English)
          http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang  
Weibo: 姜宁willem





On Wednesday, December 12, 2012 at 6:06 AM, cmuel...@apache.org 
(mailto:cmuel...@apache.org) wrote:

> Author: cmueller
> Date: Tue Dec 11 22:06:32 2012
> New Revision: 1420455
>  
> URL: http://svn.apache.org/viewvc?rev=1420455&view=rev
> Log:
> CAMEL-5844: Camel Tracer not showing some EIP names
>  
> Modified:
> camel/trunk/camel-core/src/main/java/org/apache/camel/processor/WrapProcessor.java
>  
> Modified: 
> camel/trunk/camel-core/src/main/java/org/apache/camel/processor/WrapProcessor.java
> URL: 
> http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/processor/WrapProcessor.java?rev=1420455&r1=1420454&r2=1420455&view=diff
> ==============================================================================
> --- 
> camel/trunk/camel-core/src/main/java/org/apache/camel/processor/WrapProcessor.java
>  (original)
> +++ 
> camel/trunk/camel-core/src/main/java/org/apache/camel/processor/WrapProcessor.java
>  Tue Dec 11 22:06:32 2012
> @@ -19,14 +19,14 @@ package org.apache.camel.processor;
> import java.util.List;
>  
> import org.apache.camel.Processor;
> +import org.apache.camel.Traceable;
> import org.apache.camel.util.ServiceHelper;
>  
> /**
> * A processor which ensures wrapping processors is having lifecycle handled.
> - *
> - * @version  
> */
> -public class WrapProcessor extends DelegateAsyncProcessor {
> +public class WrapProcessor extends DelegateAsyncProcessor implements 
> Traceable {
> +
> private final Processor wrapped;
>  
> public WrapProcessor(Processor processor, Processor wrapped) {
> @@ -38,6 +38,10 @@ public class WrapProcessor extends Deleg
> public String toString() {
> return "Wrap[" + wrapped + "] -> " + processor;
> }
> +  
> + public String getTraceLabel() {
> + return "wrap[" + wrapped + "]";
> + }
>  
> @Override
> public List<Processor> next() {
>  



Reply via email to