On Sun, Jan 20, 2013 at 7:52 PM, Raul Kripalani <r...@evosent.com> wrote: > Hi, > > Discussion about those failures on this ticket: CAMEL-5974. I made an > improvement on the threading model of the camel-jms component, but > committed outdated code :( This morning I backed out the changes on both > camel-2.10.x and trunk. I'm now testing locally and will commit again > during this evening. > > The change is a small one (replace SimpleAsyncTaskExecutor - SATE - with > ThreadPoolTaskExecutor - TPTE), but the impact w.r.t. to thread management > is large - especially when using dynamically scaled JMS consumers. With the > SATE, threads are constantly created and destroyed; with TPTE, threads will > be re-used and eventually timed out. > > In my new approach, I'm introducing an option in camel-jms so that users > can select the behaviour they want (SATE or TPTE). By default, the old > behaviour (SATE) is used. >
This sounds good. I was actually about to suggest that on the JIRA ticket. A new option so people could easily choose among the default working way. And the new one. Also note that the default way is what spring jms does out of the box. So I guess that combo is used a lot by people, as they most likely wont set a custom task executor on spring but use it as is. I would suggest that you put what you wrote as a comment on the JIRA ticket. Then we wont lose this information when people in the future take a look at the JIRA ticket. > Regards, > > *Raúl Kripalani* > Apache Camel Committer > Enterprise Architect, Program Manager, Open Source Integration specialist > http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani > http://blog.raulkr.net | twitter: @raulvk <http://twitter.com/raulvk> > > On Thu, Jan 17, 2013 at 5:28 PM, Hadrian Zbarcea <hzbar...@gmail.com> wrote: > >> I started dry run builds in preparation of release. There are a bunch of >> failures on my machine, especially JMS. Not sure what the cause yet, >> looking into it. >> >> Cheers, >> Hadrian >> >> >> On 01/11/2013 06:07 PM, Christian Müller wrote: >> >>> Find my comments inline. >>> >>> Best, >>> Christian >>> >>> On Mon, Jan 7, 2013 at 2:31 PM, Claus Ibsen <claus.ib...@gmail.com> >>> wrote: >>> >>> Hi >>>> >>>> I think we should start closing down on the upcoming Camel 2.11 release. >>>> >>>> +1 >>> >>> >>>> There is a few important tickets which IMHO needs to be resolved >>>> before we are in shape. >>>> >>>> Two of my tickets are target for 2.11.0 and I will fix they in the next >>> days. >>> >>> >>>> 1) >>>> New set of OSGi bundles from the SMX team. >>>> There is some new Camel components and JAR upgrades that requires a >>>> new set of OSGi bundles. >>>> >>>> 2) >>>> Upgrade to Scala 2.10 >>>> The 3rd party component which we depend on in camel-web have been >>>> upgraded to Scala 2.10 (eg scalate). >>>> So we ought to be in a position to upgrade camel-scala to Scala 2.10. >>>> What is missing is an OSGi bundle for Scala 2.10. (eg see #1) >>>> >>>> 3) >>>> Apache Karaf 2.3.1 release >>>> >>>> We need Karaf 2.3.x to support Spring 3.1 out of the box. Currently it >>>> has an issue causing both Spring 3.0 and 3.1 >>>> to be installed if you install Camel in Karaf. >>>> >>>> There is a post on Karaf @dev about this, and the Karaf team seems >>>> willingly to fix this. And hopefully cut a new release >>>> with this fix. >>>> >>>> 4) >>>> We should revisit the open ticket, and get stuff either fixed or >>>> postponed to either Camel 2.12 or 2.11.1. >>>> >>>> Two of my tickets are target for 2.11.0 and I will fix they in the next >>> days. >>> >>> >>>> 5) >>>> Look at CI and fix any test issues and other build issues. >>>> I think there is a camel-jclouds failure. >>>> >>>> 6) >>>> If there is stuff you want to be included in Camel 2.11, then let us >>>> know. >>>> >>>> >>>> >>>> -- >>>> Claus Ibsen >>>> ----------------- >>>> Red Hat, Inc. >>>> FuseSource is now part of Red Hat >>>> Email: cib...@redhat.com >>>> Web: http://fusesource.com >>>> Twitter: davsclaus >>>> Blog: http://davsclaus.com >>>> Author of Camel in Action: http://www.manning.com/ibsen >>>> >>>> >>> >>> >>> -- >>> >>> -- Claus Ibsen ----------------- Red Hat, Inc. FuseSource is now part of Red Hat Email: cib...@redhat.com Web: http://fusesource.com Twitter: davsclaus Blog: http://davsclaus.com Author of Camel in Action: http://www.manning.com/ibsen