Hi Dan Still I really can not follow you as first you say:
> The original poms were causing the generated code to get compiled with the > rest of the sources, stuck in target/classes, and then output into the > jars. Having test specific stuff in the final jars is not really a good > thing. And as I said I can't find any generated test related classes inside the final JAR, neither on the central repo: http://repo1.maven.apache.org/maven2/org/apache/camel/camel-cxf/2.10.4/camel-cxf-2.10.4.jar Nor with the CURRENT trunk code on my local workspace AFTER my commit: ~/dev/workspace/camel/components/camel-cxf/target/camel-cxf-2.12-SNAPSHOT.jar You say: > That's because we're currently using the maven-bundle-plugin to filter out > those classes by not adding them to the exports. That's a separate issue > and a bit bizzarre. Anyway even after my fix the CURRENT trunk code does NOT include any test related classes under the path "camel/components/camel-cxf/target/classes" so that I hope with can keep hold on this until http://jira.codehaus.org/browse/MECLIPSE-409 is fixed (if at all). Babak dk...@apache.org wrote > On Apr 8, 2013, at 4:10 PM, Babak Vahdat < > babak.vahdat@ > > wrote: > Can you elaborate this main "fix" a bit more as looking at the following >> latest released final JAR of camel-cxf on the central repo I don't find >> any test relevant generated class like "org.apache.camel.pizza.Pizza" >> which gets generated through >> "camel-cxf/src/test/resources/pizza_service.wsdl": >> >> http://repo1.maven.apache.org/maven2/org/apache/camel/camel-cxf/2.10.4/came >> l-cxf-2.10.4.jar >> >> >> The same goes for my current local SNAPSHOT JAR from trunk >> camel-cxf-2.12-SNAPSHOT.jar! > > That's because we're currently using the maven-bundle-plugin to filter out > those classes by not adding them to the exports. That's a separate issue > and a bit bizzarre. > > However, if you checkout 2.10.x-fixes (haven't applied the fixes there > yet) and build, you will see all the test classes in > target/classes/org/apache/camel/pizza and such which then affects latter > tests (from maven command line) as the classes dir can be added which they > would be present for (if you run "mvn test" instead of "mvn install"). > >> Questions: >> - Is there any JIRA ticket describing this problem so I can understand >> the >> issue you've already fixed regarding this? >> - Is there any commit of yours other than the following I'm missing which >> resolved the problem you're describing here: >> >> http://svn.apache.org/viewvc?view=revision&revision=r1458383 > > It was semi-part of stuff I discovered while working on: > > http://svn.apache.org/viewvc?view=revision&revision=r1458364 > > as revisions 1457229 and/or 1457242 caused complete eclipse breakage due > to overlapping resources directories with the output directories. > (generating a resource directly into target/classes, but adding > target/classes as a resource directory, caused the generated eclipse > project to not be valid). Evolutions of discovery while diagnosing that > issue. > > Dan > > >> >> Babak >> >>> >>> >>>> Actually the root cause of the problem is this closed/duplicate >>>> JIRA ticket: >>>> >>>> http://jira.codehaus.org/browse/MECLIPSE-409 >>>> >>>> So although I agree with you that generate-test-sources is the RIGHT >>>> phase >>>> to use, more importantly I prefer to NOT break things already working >>>> EVEN >>>> IF they're technically wrong from a Maven standpoint of view. So better >>>> let's keep things working as they ALREADY do until such JIRA tickets >>>> are >>>> properly fixed. Then we can of course upgrade to whatever >>>> maven-eclipse-plugin version this issue has been already fixed with. >>>> >>>> Babak >>>> >>>> >>>>> >>>>> >>>>> Dan >>>>> >>>>> >>>>>> >>>>>> Babak >>>>>> >>>>>> >>>>>> Babak Vahdat wrote >>>>>>> Hi >>>>>>> >>>>>>> Using eclipse I've got some similar build problems as well by some >>>>>>> modules >>>>>>> like camel-soap or camel-cxf where eclipse is not able to see any of >>>>>>> the >>>>>>> Java sources being generated by cxf-codegen-plugin. I digged a bit >>>>>>> into >>>>>>> this and came to the following commit: >>>>>>> >>>>>>> http://svn.apache.org/viewvc?view=revision&revision=r1458383 >>>>>>> >>>>>>> As an example if I revert the following change of this commit then >>>>>>> eclipse >>>>>>> is happy and camel-soap builds properly again: >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://svn.apache.org/viewvc/camel/trunk/components/camel-soap/pom.xml >>>>>>> ?r >>>>>>> 1=1458383&r2=1458382&pathrev=1458383 >>>>>>> >>>>>>> Other way of fixing the compilation problem under eclipse for this >>>>>>> module >>>>>>> is to add the following source folder *manually*: >>>>>>> >>>>>>> camel/components/camel-soap/target/generated/src/test/java >>>>>>> >>>>>>> And yes I was suspicious about my old 2011 eclipse installation >>>>>>> could >>>>>>> be >>>>>>> the root cause of this build problem, but upgrading to the newest >>>>>>> version: >>>>>>> >>>>>>> Version: Juno Service Release 2 >>>>>>> Build id: 20130225-0426 >>>>>>> >>>>>>> didn't make any change. >>>>>>> >>>>>>> Anybody else using eclipse having similar build problems on trunk? >>>>>>> >>>>>>> Babak >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> View this message in context: >>>>>> >>>>>> http://camel.465427.n5.nabble.com/IDEA-12-1-cannot-build-Apache-Camel-p >>>>>> ro >>>>>> ject-anymore-tp5730468p5730491.html >>>>>> Sent from the Camel Development mailing list archive at Nabble.com. >>>>> >>>>> -- >>>>> Daniel Kulp >>>>> > dkulp@ > - http://dankulp.com/blog >>>>> Talend Community Coder - http://coders.talend.com >>>>> >>>> >>>> >>> >>> -- >>> Daniel Kulp >>> > dkulp@ > - http://dankulp.com/blog >>> Talend Community Coder - http://coders.talend.com >>> >> >> > > -- > Daniel Kulp > dkulp@ > - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com -- View this message in context: http://camel.465427.n5.nabble.com/IDEA-12-1-cannot-build-Apache-Camel-project-anymore-tp5730468p5730571.html Sent from the Camel Development mailing list archive at Nabble.com.
