Hi Good idea about the option true|false. I logged a ticket https://issues.apache.org/jira/browse/CAMEL-6282
On Sun, Apr 14, 2013 at 1:54 PM, Raul Kripalani <r...@evosent.com> wrote: > Yes, in that case I agree too this is the most sensible option. > > +1 > > Raúl. > On 14 Apr 2013 12:38, "Christian Müller" <christian.muel...@gmail.com> > wrote: > >> +1 for an option so the user can decide whether he want the stats or not. >> >> Sent from a mobile device >> Am 14.04.2013 13:30 schrieb "Babak Vahdat" <babak.vah...@swissonline.ch>: >> >> > >> > >> > Am 14.04.13 13:09 schrieb "Raul Kripalani" unter <r...@evosent.com>: >> > >> > >Hi Claus >> > > >> > >+1 to redo the release. >> > > >> > >These stats are really useful for profiling. >> > > >> > >I'd rather turn the counters into plain longs and make it clear to users >> > >(in the log statements and documentation) that the figures are merely >> > >indicative and not fully accurate. >> > >> > Hi >> > >> > I think more than accuracy and precision using plain long the main >> problem >> > would be to have really WIRED numbers, that's also NEGATIVE numbers even >> > if you would ONLY increment, mostly reproduciable on multi-core boxes >> > (verifying/testing this is trivial & straightforward). >> > >> > Just wonder if we could disable this per default but let the stats get >> > enabled somehow through a flag, property or the likes. Then ppl can >> decide >> > on their own what's more important to them: better performance versus >> > statistics. >> > >> > Babak >> > >> > > >> > >Regards, >> > >Raúl. >> > > On 14 Apr 2013 09:42, "Claus Ibsen" <claus.ib...@gmail.com> wrote: >> > > >> > >> Hi >> > >> >> > >> All the examples with those WARN about thread pools on shutdown should >> > >> been fixed on trunk. >> > >> >> > >> I wonder if we should redo the release as I want to fix by removing >> > >> the overhead of these stats. Its IMHO better to have higher >> > >> performance. And there is no good way to do the counters without the >> > >> threads contention. We could use plain long for the counters, but then >> > >> they are not accurate as a ++ on a long value is not atomic. >> > >> >> > >> https://issues.apache.org/jira/browse/CAMEL-6264 >> > >> >> > >> >> > >> >> > >> On Sat, Apr 13, 2013 at 7:25 PM, Christian Müller >> > >> <christian.muel...@gmail.com> wrote: >> > >> > I tested the following examples: >> > >> > >> > >> > camel-example-cxf-blueprint: >> > >> > OK >> > >> > >> > >> > camel-example-cxf-osgi >> > >> > FAILED (see CAMEL-6257) >> > >> > >> > >> > camel-example-aggregate >> > >> > OK, but it logged some WARNings by stopping the service: >> > >> > [amel) thread #3 - ShutdownTask] DefaultExecutorServiceManager INFO >> > >> > Waited 10.002 seconds for ExecutorService: >> > >> > >> org.apache.camel.util.concurrent.RejectableThreadPoolExecutor@2f971f66 >> > >> >> > >> >>[stream://in?promptDelay=1000&promptMessage=Enter+a+number+to+be+added+%2 >> > >>8enter+STOP+to+end%2C+and+Ctrl-C+to+shutdown+Camel%29%3A+] >> > >> > to terminate... >> > >> > [amel) thread #3 - ShutdownTask] DefaultExecutorServiceManager WARN >> > >> > Forcing shutdown of ExecutorService: >> > >> > >> org.apache.camel.util.concurrent.RejectableThreadPoolExecutor@2f971f66 >> > >> >> > >> >>[stream://in?promptDelay=1000&promptMessage=Enter+a+number+to+be+added+%2 >> > >>8enter+STOP+to+end%2C+and+Ctrl-C+to+shutdown+Camel%29%3A+] >> > >> > due first await termination elapsed. >> > >> > >> > >> > camel-example-bam >> > >> > some ERRORs in the log >> > >> > >> > >> > camel-example-cafe >> > >> > OK >> > >> > >> > >> > camel-example-cdi >> > >> > OK >> > >> > >> > >> > camel-example-console >> > >> > OK, but it logged some WARNings by stopping the service: >> > >> > [el-1) thread #2 - ShutdownTask] DefaultExecutorServiceManager INFO >> > >> > Waited 10.002 seconds for ExecutorService: >> > >> > >> org.apache.camel.util.concurrent.RejectableThreadPoolExecutor@1a3a2a52 >> > >> [stream://in?promptMessage=Enter+something%3A+] >> > >> > to terminate... >> > >> > [el-1) thread #2 - ShutdownTask] DefaultExecutorServiceManager WARN >> > >> > Cannot completely force shutdown of ExecutorService: >> > >> > >> org.apache.camel.util.concurrent.RejectableThreadPoolExecutor@1a3a2a52 >> > >> [stream://in?promptMessage=Enter+something%3A+] >> > >> > due second await termination elapsed. >> > >> > >> > >> > camel-example-cxf >> > >> > OK >> > >> > >> > >> > camel-example-cxf-proxy >> > >> > OK, but the README needs an update because we use dynamic ports >> > >> (available >> > >> > port finder). DONE >> > >> > >> > >> > camel-example-docs >> > >> > Doesn't generated the images for the index.html file >> > >> > >> > >> > Still testing the other examples... >> > >> > >> > >> > Best, >> > >> > Christain >> > >> > >> > >> > >> > >> > On Thu, Apr 11, 2013 at 12:50 PM, Christian Müller < >> > >> > christian.muel...@gmail.com> wrote: >> > >> > >> > >> >> After 9 month of development, we have a new minor release candidate >> > >> >> apache-camel-2.11.0 ready. >> > >> >> It comes with 659 issues resolved: new features, improvements and >> bug >> > >> >> fixes [1]. You can find the release notes here [2]. >> > >> >> >> > >> >> Please find the staging repo here: >> > >> >> >> > >>https://repository.apache.org/content/repositories/orgapachecamel-092/ >> > >> >> >> > >> >> The tarballs are here >> > >> >> >> > >> >> >> > >> >> > >> >> > >> https://repository.apache.org/content/repositories/orgapachecamel-092/org >> > >>/apache/camel/apache-camel/2.11.0/ >> > >> >> >> > >> >> Tag: >> > >> >> http://svn.apache.org/repos/asf/camel/tags/camel-2.11.0/ >> > >> >> >> > >> >> Please review, help out with testing and vote to approve this >> release >> > >> >> binary. Please mention what you tested to prevent duplicate work. >> > >>Your >> > >> vote >> > >> >> counts! >> > >> >> >> > >> >> [ ] +1 Release the binary as Apache Camel 2.11.0 >> > >> >> [ ] -1 Veto the release (provide specific comments) >> > >> >> Vote is open for at least 72 hours. >> > >> >> >> > >> >> Thanks in advance, >> > >> >> Christian >> > >> >> >> > >> >> [1] >> > >> >> >> > >> >> > >> >> > >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CAMEL%20AND%20 >> > >>fixVersion%20%3D%20%222.11.0%22 >> > >> >> [2] >> > >> >> >> > >> >> > >> >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311211 >> > >>&version=12321695 >> > >> >> >> > >> >> > >> >> > >> >> > >> -- >> > >> Claus Ibsen >> > >> ----------------- >> > >> Red Hat, Inc. >> > >> FuseSource is now part of Red Hat >> > >> Email: cib...@redhat.com >> > >> Web: http://fusesource.com >> > >> Twitter: davsclaus >> > >> Blog: http://davsclaus.com >> > >> Author of Camel in Action: http://www.manning.com/ibsen >> > >> >> > >> > >> > >> -- Claus Ibsen ----------------- Red Hat, Inc. FuseSource is now part of Red Hat Email: cib...@redhat.com Web: http://fusesource.com Twitter: davsclaus Blog: http://davsclaus.com Author of Camel in Action: http://www.manning.com/ibsen
