Please see my comments in the below email. I don't think those issues are blockers of Camel 2.11.0 release.
-- Willem Jiang Red Hat, Inc. FuseSource is now part of Red Hat Web: http://www.fusesource.com | http://www.redhat.com Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English) http://jnn.iteye.com (http://jnn.javaeye.com/) (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Friday, April 19, 2013 at 3:33 PM, Jan Matèrne (jhm) wrote: > I am neither a Camel nor a Maven professional, so just a few thoughts ;) > > https://repository.apache.org/content/repositories/orgapachecamel-112/org/ap > ache/camel/apache-camel/2.11.0/apache-camel-2.11.0.pom > * The POM refers to a parent POM as relative "../parent". (I think > resolution via group:artifact:version wins if its not present there?) relative path will help maven to find out the parent pom if the pom is not installed. > * Packaging as POM? (Requirement when just assembling?) yeah, it is needed. > * Properties <maven.test.skip>true? (Because tests were executed in steps > before?) sometime we need to use mvn clean install -Dtest=false to install the artifacts without running the test. > * Dependency section: there are empty lines between blocks (Geronimo, SL4J) > - empty line is missing between spring-test and osgi > * some indents are with TABs > * <build> is more indented than <dependencies> They are format issues, we can fix them later. > > https://repository.apache.org/content/repositories/orgapachecamel-112/org/ap > ache/camel/apache-camel/2.11.0/apache-camel-2.11.0.zip > * doc/manual contains two manuals: 2.11.0 and 2.12-SNAPSHOT (both in html > and pdf) Why having the SNAPSHOT here? (I think this one of Claus points.) I guess it is caused by Christian's box doesn't clean up the old files. > * NOTICE.txt: Camel Copyright 2007-2012? We have 2013 now. Claus fixed this in the trunk. > * KEYS-file only in the src-distro? KEYS-file is in the svn repository, so it's a part of src-distro. > > https://repository.apache.org/content/repositories/orgapachecamel-112/org/ap > ache/camel/apache-camel/2.11.0/apache-camel-2.11.0-src.zip > * doap.rdf: > ** copyright 2008 We need to update it. > ** <license rdf:resource="http://usefulinc.com/doap/licenses/asl20"; /> > isnt there a resource on ASF servers? I'm not sure about if the file is served in ASF server , but the link in our pom is broken. > ** bug-database http://issues.apache.org/activemq/browse/CAMEL works as > its redirected to https://issues.apache.org/jira/browse/CAMEL, but should be > updated Yeah, we need to update it. > ** maintainer: only Christian Mueller? We need add more names :) > * KEYS could contain more entries ... > * NOTICE.txt: differs from the bin-distro. (Only Camel notice.) (Is the > bin-version merged from several sources?) > * pom.xml: inceptionYear=2007 whereas in the doap.rdf means > created=2008-12-17 Camel is created as subproject of ActiveMQ in 2007. But it is became a top level Apache project in later 2008 > > * <scm> connection+developerConnection both uses svn:https - no http? This link will be used by maven release plugin, and we need to write right of it. > * apache-camel/src/main/release/NOTICE.txt: copyright 2012, interface21 > adresses > * apache-camel/src/main/resources/META-INF/NOTICE.txt: copyright 2005-2006 > (maybe we should check all "copyright" statements ...) > * are there duplications? buildingtools/src/main/resources + > buildingtools/META-INF We need to fix that. > * camel-core/pom.xml > ** defines a dependency on com.googlecode.concurrentlinkedhashmap. Is an > entry in the NOTICE required? Not sure about it. > ** javadoc links to http://download.oracle.com/javase/6/docs/api/ Is Camel > build against Java6? (As Java6 is out of life afaik). Yes, Camel is built with Java6 > * > > All over the Archive there are LICENSE and NOTICE files scattered. Often > with the same content. We need to ship the LICENSE and NOTICE file for each Apache Camel jars. > > > Jan > > > -----Ursprüngliche Nachricht----- > > Von: Claus Ibsen [mailto:claus.ib...@gmail.com] > > Gesendet: Freitag, 19. April 2013 08:22 > > An: dev > > Betreff: Re: [VOTE] Release Apache Camel 2.11.0 (take 4) > > > > +1 > > > > This release looks fine for me. > > Tried some of the examples and they now work as expected. > > > > We can fix the readme/notice file, and the duplicate manuals for next > > releases. > > > > > > On Wed, Apr 17, 2013 at 10:11 PM, Christian Müller > > <christian.muel...@gmail.com (mailto:christian.muel...@gmail.com)> wrote: > > > After 9 month of development, we have a new minor release candidate > > > apache-camel-2.11.0 ready. > > > It comes with 679 issues resolved: new features, improvements and bug > > > fixes [1]. You can find the release notes here [2]. > > > > > > Please find the staging repo here: > > > https://repository.apache.org/content/repositories/orgapachecamel- > > > > > > 112/ > > > > > > The tarballs are here > > > https://repository.apache.org/content/repositories/orgapachecamel- > > > > > > 112/ > > > org/apache/camel/apache-camel/2.11.0/ > > > > > > Tag: > > > http://svn.apache.org/repos/asf/camel/tags/camel-2.11.0/ > > > > > > Please review, help out with testing and vote to approve this release > > > binary. Please mention what you tested to prevent duplicate work. > > > > > > Your > > > vote counts! > > > > > > [ ] +1 Release the binary as Apache Camel 2.11.0 [ ] -1 Veto the > > > release (provide specific comments) Vote is open for at least 72 > > > hours. > > > > > > Thanks in advance, > > > Christian > > > > > > [1] > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20CAMEL%20AND > > > %20fixVersion%20%3D%20%222.11.0%22 > > > [2] > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311 > > > 211&version=12321695 > > > > > > > > > > > > -- > > Claus Ibsen > > ----------------- > > Red Hat, Inc. > > FuseSource is now part of Red Hat > > Email: cib...@redhat.com (mailto:cib...@redhat.com) > > Web: http://fusesource.com > > Twitter: davsclaus > > Blog: http://davsclaus.com > > Author of Camel in Action: http://www.manning.com/ibsen >
