+1 (reversal of vote)
* I got to run the full test suite too. Everything works except one
test, but it's a test issue not a product issue.
* Checked signatures, all looks good.
* I checked with Dan this morning. For him everything looked good. Dan
mentioned that there was a discussion on the maven lists related to what
I experienced, but there is no good solution. After picking the first
2.10.5 tag, I only did a `git pull`, without a `git fetch --tags`, so
the tag in my local clone was not refreshed and hence the version I got
to see. This would not happen on a fresh copy, therefore it's not an
issue as far as the release is concerned.
* The camel-itests are still an issue that needs resolving, but not a
blocker for the release. It needs to be resolved though. For instance
camel-itest-osgi was a released artifact up until 2.10.2, we should
probably move it somewhere else if we don't plan to release. Anyway, a
discussion for another time.
* Singing the tag still an issue to be resolved, not a blocker.
Thanks Christian for the first release from the git repo!
Hadrian
On 06/25/2013 03:18 PM, Christian Müller wrote:
Hello Hadrian!
Can you please share a link to the faulty pom.xml files!? I checked Nexus
[1] and Git [2] and they look good.
[1]
https://repository.apache.org/content/repositories/orgapachecamel-058/org/apache/camel/camel-core/2.10.5/camel-core-2.10.5.pom
[2]
https://git-wip-us.apache.org/repos/asf?p=camel.git;a=blob;f=camel-core/pom.xml;h=c1cf6b896c47ddb6cd256327a3be25452937cc31;hb=b080909f1db853e5d91e67f78a248a9950481d18
Best,
Christian
-----------------
Software Integration Specialist
Apache Camel committer: https://camel.apache.org/team
V.P. Apache Camel: https://www.apache.org/foundation/
Apache Member: https://www.apache.org/foundation/members.html
https://www.linkedin.com/pub/christian-mueller/11/551/642
On Tue, Jun 25, 2013 at 3:37 AM, Hadrian Zbarcea <hzbar...@gmail.com> wrote:
-1 (reluctantly)
* Checking out the tag I see that all poms use 2.10.5-SNAPSHOT. Not good
for a release.
* Building from the tag went fine (didn't run all tests yet, but I plan to
tomorrow). However, in ./tests, both camel-itest-osgi and camel-itest-karaf
are excluded from the build, and what's worse, point to older versions of
the parent. We should have caught this earlier.
* Signing the tag is important (imho), but that's not a blocker, that's
only a -0.
Hadrian
On 06/23/2013 05:35 AM, Christian Müller wrote:
After 4 month of development, we have a new bug fix release candidate
apache-camel-2.10.5 ready.
It comes with 108 issues resolved [1]. You can find the release notes here
[2].
Please find the staging repo here:
https://repository.apache.org/**content/repositories/**
orgapachecamel-058/<https://repository.apache.org/content/repositories/orgapachecamel-058/>
The tarballs are here
https://repository.apache.org/**content/repositories/**
orgapachecamel-058/org/apache/**camel/apache-camel/2.10.5/<https://repository.apache.org/content/repositories/orgapachecamel-058/org/apache/camel/apache-camel/2.10.5/>
Tag:
http://svn.apache.org/repos/**asf/camel/tags/camel-2.10.5/<http://svn.apache.org/repos/asf/camel/tags/camel-2.10.5/>
Please review, help out with testing and vote to approve this release
binary. This is our first release which uses the new Camel Git repository
at
https://git-wip-us.apache.org/**repos/asf?p=camel.git<https://git-wip-us.apache.org/repos/asf?p=camel.git>
.
Please mention what you tested to prevent duplicate work. Your vote
counts!
Some notable remarks:
- At present, we don't use signed tags in Git. I don't think it's possible
at present because of the unresolved issue [3]. I also don't think this
is
necessary, because we did had a similar thing in SVN.
- Because I didn't push my local changes to the central repository until
today morning and Claus did some changes on the camel-2.10.x branch (no
blaming ;-) ), it now looks like the tag 2.10.5 is not part of the
camel-2.10.x branch because I had to do a rebase before I could push the
changes. Not sure whether this is an issue. If it's, I will will change
the
maven-release-plugin settings to push the changes immediately by doing the
release:prepare and undo the release.
- The Camel manual still looks good. May be the Confluence update wasn't
started/done at the time I build the release.
[ ] +1 Release the binary as Apache Camel 2.10.5
[ ] -1 Veto the release (provide specific comments)
Vote is open for at least 72 hours.
[1]
https://issues.apache.org/**jira/issues/?jql=project%20%**
3D%20CAMEL%20AND%20fixVersion%**20%3D%20%222.10.5%22<https://issues.apache.org/jira/issues/?jql=project%20%3D%20CAMEL%20AND%20fixVersion%20%3D%20%222.10.5%22>
[2]
https://issues.apache.org/**jira/secure/ReleaseNote.jspa?**
projectId=12311211&version=**12324024<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311211&version=12324024>
[3]
http://jira.codehaus.org/**browse/SCM-486<http://jira.codehaus.org/browse/SCM-486>
Thanks in advance,
Christian
-----------------
Software Integration Specialist
Apache Camel committer: https://camel.apache.org/team
V.P. Apache Camel:
https://www.apache.org/**foundation/<https://www.apache.org/foundation/>
Apache Member:
https://www.apache.org/**foundation/members.html<https://www.apache.org/foundation/members.html>
https://www.linkedin.com/pub/**christian-mueller/11/551/642<https://www.linkedin.com/pub/christian-mueller/11/551/642>
