Very interesting. That sounds like lots of headaches, so keeping optional is fine if it solves that. I was just noticing in Intellij that it couldn't compile camel-sql because it didn't bring in that dependency since it was marked optional. But that's an easy headache to fix compared to the ones you mention :)
On Sat, Aug 17, 2013 at 1:11 AM, Babak Vahdat <babak.vah...@swissonline.ch>wrote: > Hi Christian, > > I think having the optional flag set to true is indeed good as we used to > have problems to build & run the tests using Java 6 profile on the > CI-Server, e.g. the profile "Camel.trunk.fulltest". See also here: > > https://github.com/apache/camel/blob/master/components/pom.xml#L221 > > Also note that the apt module by itself brings a transitive dependency to > spi-annotations: > > https://github.com/apache/camel/blob/master/tooling/apt/pom.xml#L43 > > So I guess removing that optional flag would cause the same problems again, > see also this thread: > > > http://camel.465427.n5.nabble.com/Our-builds-looks-really-bad-tp5731673p5731743.html > > There's also another ODD issue we're facing with our Jenkins builds but > unfortunately it's still not resolved, causing a lot of yellow/red bubbles > by our profiles as well as other Apache projects: > > https://issues.apache.org/jira/browse/INFRA-6218 > > Which is another story... > > Babak > > > ceposta wrote > > Apply this for the fix :) > > > > > > > > diff --git a/camel-core/pom.xml b/camel-core/pom.xml > > index cd2f201..7409c90 100755 > > --- a/camel-core/pom.xml > > +++ b/camel-core/pom.xml > > @@ -99,7 +99,6 @@ > > > > <groupId> > > org.apache.camel > > </groupId> > > > > <artifactId> > > spi-annotations > > </artifactId> > > > > <version> > > ${project.version} > > </version> > > - > > <optional> > > true > > </optional> > > > > </dependency> > > > > <dependency> > > > > On Fri, Aug 16, 2013 at 1:43 PM, Christian Posta > > < > > > christian.posta@ > > > >wrote: > > > >> So in camel-core, the spi-annotations dependency is marked "optional" in > >> the pom. > >> > >> > > >> > > <dependency> > >> > > <groupId> > > org.apache.camel > > </groupId> > >> > > <artifactId> > > spi-annotations > > </artifactId> > >> > > <version> > > ${project.version} > > </version> > >> > > <optional> > > true > > </optional> > >> > > </dependency> > >> > >> But is it optional? Seems to be used in some of the core components, so > >> should be there, right? > >> > >> -- > >> *Christian Posta* > >> http://www.christianposta.com/blog > >> twitter: @christianposta > >> > > > > > > > > -- > > *Christian Posta* > > http://www.christianposta.com/blog > > twitter: @christianposta > > > > > > -- > View this message in context: > http://camel.465427.n5.nabble.com/spi-annotations-tp5737435p5737448.html > Sent from the Camel Development mailing list archive at Nabble.com. > -- *Christian Posta* http://www.christianposta.com/blog twitter: @christianposta
