Doesn't the checkstyle plugin add a bit of time to the build? I can see why it's not default!
On 28 May 2014 06:54, Willem Jiang <willem.ji...@gmail.com> wrote: > Current the checkstyle verification only run when we do the release. > > We had some argument about enable the -Psourcecheck by default, but we > didn’t have the agreement with that. > > If you are using eclipse, the check style plugin can work very well > without running any mvn command :) > > -- > Willem Jiang > > Red Hat, Inc. > Web: http://www.redhat.com > Blog: http://willemjiang.blogspot.com (English) > http://jnn.iteye.com (Chinese) > Twitter: willemjiang > Weibo: 姜宁willem > > > > On May 28, 2014 at 7:09:24 PM, Aki Yoshida (elak...@gmail.com) wrote: > > Hi, > > I saw Willem fixing some of my checkstyle violation (Thanks Willem) > > and realized belately that the checkstyle is not active by default in > > camel when doing mvn clean install. > > > > I thought that the checkstyle was enabled as in cxf by default. > > > > When I ran mvn -Psourcecheck, I saw some additional checkstyle > > violation from my yesterday's commit. I'll fix these now. > > > > But I wanted to ask if this default deactivation of stylecheck > > intended? I personally think it would be better to have the stylecheck > > activated for the default install. > > > > I see some other people also committing violating code. So at least, > > this current default build behavior is not known to everyone and I > > thought I should bring it up. > > > > regards, aki > > > > -- Matt Sicker <boa...@gmail.com>
