On 07/01/15 10:18, Daniel Pocock wrote: > On 07/01/15 03:19, Willem Jiang wrote: >> I just send a PR by applying the patch of creating OSGi bundle for jSMPP. >> Now Camel can consume the new jSMPP bundle from the Official release :) > > I've just released jSMPP 2.2.1 with that change, please let me know if > it looks correct, it has been released through Sonatype and should be > available for Maven users soon. > > Would you be able to tweak the camel-smpp/pom.xml as well?
Actually, I tried this on a branch and I found that some of the test cases needed to be tweaked for some API changes https://github.com/dpocock/camel/tree/dpocock-jsmpp-update I made an issue for it too: https://issues.apache.org/jira/browse/CAMEL-8215 After compiling, some of the unit tests fail and one gives an error I'll need to look more closely to see what else changed in jSMPP and whether it needs to be tweaked in jSMPP or in camel-smpp There were some things in the unit tests that were obvious though so they are already fixed. One of the things that changes is that Alphabet now supports all the permitted values and it is not always assumed that the lower 2 bits are the message class. This may impact test cases that expect a specific binary data coding value.
