GitHub user rhuss opened a pull request:
https://github.com/apache/camel/pull/1581
Polished ComponentVerifier interface
The following major changes are suggested:
* Using of interfaces and enums instead of string constants for error
fields. This has the advantage of being typesafe but still extensible (custom
fields can be easily added)
* Renamed Error to VerificationError as it conflicts with java.lang.Error
which is allways imported
* Documentation to the interface
* Consolidation of provided constants, together with @lburgazzoli
* Adapted the using components (mainly http, http4, twitter, salesforce)
The initial work and discussion happened on
https://github.com/rhuss/camel/pull/1 please refer to the discussion there, too.
The natural starting point is
[ComponentVerifier](https://github.com/rhuss/camel/blob/2db634b81b8511217b0053a20dd888866e9fc662/camel-core/src/main/java/org/apache/camel/ComponentVerifier.java)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rhuss/camel pr/connector-api-squashed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1581
----
commit 2db634b81b8511217b0053a20dd888866e9fc662
Author: Roland Huà <[email protected]>
Date: 2017-03-29T08:25:03Z
Polished ComponentVerifier interface
The following major changes are suggested:
* Using of interfaces and enums instead of string constants for error
fields. This has the advantage of being typesafe but still extensible (custom
fields can be easily added)
* Renamed Error to VerificationError as it conflicts with java.lang.Error
which is allways imported
* Documentation to the interface
* Consolidation of provided constants, together with @lburgazzoli
* Adapted the using components (mainly http, http4, twitter, salesforce)
The initial work and discussion happened on
https://github.com/rhuss/camel/pull/1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
