Hi Gregor Thanks for fixing up those mistakes on the 2.18.x branch.
I am +1 on backporting those other commits so the properties component is more up to date as is in 2.19.x branches so it can have the same bug fix which we backported initially. I assume the branch is in good shape now, and that we see the RC over the weekend. On Sun, Sep 17, 2017 at 12:22 PM, Gregor Zurowski <gre...@list.zurowski.org> wrote: > Hi Everyone: > > I am currently getting branch camel-2.18.x ready for the release > candidate of Camel 2.18.5. I ran into issues in the camel-spring > module because of compilation errors in > BridgePropertyPlaceholderConfigurer.BridgePropertiesParser that > implements interface AugmentedPropertyNameAwarePropertiesParser of > camel-core. AugmentedPropertyNameAwarePropertiesParser was recently > changed, but hasn't been updated on branch 2.18.x. The problem can be > easily solved by updating AugmentedPropertyNameAwarePropertiesParser > accordingly, more specifically, by applying the following commits: > > cfedae0157b8b120136067178af1928d7a7669c6 > 5ef0e55459388853999662c824b77b3b59e62723 > > This changes the interfrace signature from: > > String parseUri(String text, Properties properties, String > prefixToken, String suffixToken, String propertyPrefix, String > propertySuffix, boolean fallbackToUnaugmentedProperty) throws > IllegalArgumentException; > > To the following signature (adding an additional boolean > defaultFallbackEnabled argument): > > String parseUri(String text, Properties properties, String > prefixToken, String suffixToken, String propertyPrefix, String > propertySuffix, boolean fallbackToUnaugmentedProperty, boolean > defaultFallbackEnabled) throws IllegalArgumentException; > > Just wanted to get your opinion whether we can apply such changes on > that interface within a patch release? > > Other than that, most other changes required for the RC are minor > Checkstyle fixes. > > Thanks in advance, > Gregor -- Claus Ibsen ----------------- http://davsclaus.com @davsclaus Camel in Action 2: https://www.manning.com/ibsen2
