GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2035
Fix the problem of instanceof test always return true. This instanceof test will always return true because AbstractSObjectBase is the return type of method node.getObject(). The return value of method node.getObject() might be null, it would be better to do a null test rather than an instanceof test. http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/camel master7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2035.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2035 ---- commit fc154c8acb50eca5ad6acb466a8a384081e9087c Author: Kui LIU <brucekui...@gmail.com> Date: 2017-10-12T09:12:32Z Fix the problem of instanceof test always return true. This instanceof test will always return true because AbstractSObjectBase is the return type of method node.getObject(). The return value of method node.getObject() might be null, it would be better to do a null test rather than an instanceof test. http://findbugs.sourceforge.net/bugDescriptions.html#BC_VACUOUS_INSTANCEOF ---- ---