Is the spring-cloud dep up to date ? there may be incompatibility --- Luca Burgazzoli
On Fri, Nov 2, 2018 at 11:31 AM Zoran Regvart <zo...@regvart.com> wrote: > > Hi Claus, > both are defined in `spring-cloud-consul`[1][2], looks like they > should both have @ConditionalOnMissingBean. What puzzles me is that it > worked before the upgrade, perhaps the order of beans changed? > > I think this needs to be fixed in `spring-cloud-consul`, though it > could point to a incompatibility between Spring Boot 2.0 and 2.1 -- > that's where auto-configuration is. > > zoran > > [1] > https://github.com/spring-cloud/spring-cloud-consul/blob/e8d5b575861ff39d4ea8a7fdf0eeaff6ea8dd3b8/spring-cloud-consul-discovery/src/main/java/org/springframework/cloud/consul/serviceregistry/ConsulServiceRegistryAutoConfiguration.java#L60-L64 > [2] > https://github.com/spring-cloud/spring-cloud-consul/blob/e8d5b575861ff39d4ea8a7fdf0eeaff6ea8dd3b8/spring-cloud-consul-discovery/src/main/java/org/springframework/cloud/consul/discovery/ConsulDiscoveryClientConfiguration.java#L61-L65 > > On Fri, Nov 2, 2018 at 11:26 AM, Claus Ibsen <claus.ib...@gmail.com> wrote: > > Hi > > > > This seems like a bit weird error. > > > > Is that heartbeatProperties something that is inherited from > > spring-boot itself or where does it come from? > > > > And would a fix be to add @ConditionalOnMissingBean on both of them? > > On Wed, Oct 31, 2018 at 3:54 PM Zoran Regvart <zo...@regvart.com> wrote: > >> > >> Hi Cameleers, > >> there are test failures in the `camel-spring-cloud-consul`[1], to me > >> it seems like an issue with Spring Boot auto-configuration: > >> `ConsulDiscoveryClientConfiguration::heartbeatProperties` and > >> `ConsulServiceRegistryAutoConfiguration::heartbeatProperties` try to > >> define the same bean, where only > >> `ConsulServiceRegistryAutoConfiguration::heartbeatProperties` is > >> @ConditionalOnMissingBean. > >> > >> Not sure what changed or how we can address this in Camel. > >> > >> zoran > >> > >> [1] > >> https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/spring-upgrades/2/testReport/ > >> > >> On Tue, Oct 30, 2018 at 10:23 PM, Zoran Regvart <zo...@regvart.com> wrote: > >> > Hi Cameleers, > >> > looks like the build succeeded, but is hanging for some reason (could > >> > be infrastructure related, not sure): > >> > > >> > https://builds.apache.org/view/C/view/Apache%20Camel/job/Camel/job/spring-upgrades/1/console > >> > > >> > zoran > >> > > >> > On Tue, Oct 30, 2018 at 4:19 PM, Zoran Regvart <zo...@regvart.com> wrote: > >> >> Hi Cameleers, > >> >> I've tinkered with Spring (5.1.2) and Spring Boot (2.1.0) upgrades, > >> >> any comments welcome: > >> >> > >> >> https://github.com/apache/camel/pull/2584 > >> >> > >> >> zoran > >> >> -- > >> >> Zoran Regvart > >> > > >> > > >> > > >> > -- > >> > Zoran Regvart > >> > >> > >> > >> -- > >> Zoran Regvart > > > > > > > > -- > > Claus Ibsen > > ----------------- > > http://davsclaus.com @davsclaus > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > -- > Zoran Regvart
