astefanutti commented on a change in pull request #480: add finalizer to ensure
integration children are cleaned up
URL: https://github.com/apache/camel-k/pull/480#discussion_r259062957
##########
File path: pkg/cmd/run.go
##########
@@ -84,6 +86,7 @@ func newCmdRun(rootCmdOptions *RootCmdOptions)
*cobra.Command {
cmd.Flags().BoolVar(&options.Compression, "compression", false, "Enable
store source as a compressed binary blob")
cmd.Flags().StringSliceVar(&options.Resources, "resource", nil, "Add a
resource")
cmd.Flags().StringSliceVar(&options.OpenAPIs, "open-api", nil, "Add an
OpenAPI v2 spec")
+ cmd.Flags().BoolVar(&options.Owner, "owner", true, "Use resource
ownership to cleanup child resources, if set to false finalizers are used")
Review comment:
We may want to name the option to something more explicit like
`deletion-policy` with possible values `owner` / `ownerReference` or `label` /
`labelSelector` to fit into k8s garbage collection scheme.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
