Willem JiangTwitter: willemjiangWeibo: 姜宁willem On Wed, Mar 6, 2019 at 12:39 AM Marc Carter <drekb...@gmail.com> wrote: > > I took a look at that and it's helped a bit but this does need a > retelling. For the sake of sanity, CheckStyle and Eclipse rules should > be golden - IntelliJ has decent import system for both that can be (re) > documented. However (isn't there always something...) > > a) etc/eclipse/CamelCodeFormatter.xml contains an indent of 8 which is > obviously incorrect (clashes with CS rules). Is this the correct file? > > <setting id="org.eclipse.jdt.core.formatter.indentation.size" value="8"/> > It's wrong, do you mind send a PR for it.
> b) buildingtools/camel-checkstyle.xml differs from > buildingtools/src/main/resources/camel-checkstyle.xml > > Which is correct? It's confuse the user. The check style file in the resource directory[1] is used in setting up the eclipse workspace. But I cannot find the checkstyle plugin setting with the building tools on the master branch. [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407 > > On 3/5/19 11:45 AM, Onder SEZGIN wrote: > > http://camel.apache.org/set-up-your-ide.html > > > > see this file mentioned below is on older branches on github. > > > > *etc/idea/settings.jar* > > > > On Tue, Mar 5, 2019 at 1:42 PM Marc Carter <drekb...@gmail.com> wrote: > > > >> Official instructions for IntelliJ(*) point to files that no longer > >> exist. I'm sure there's some history to this but it does mean I (and > >> anyone else not using Eclipse) is missing the checkstyle and format > >> rules that prevent poor quality checkins. > >> > >> I have learnt the command-line version but it's no substitute for your > >> IDE getting the details correct as you type! > >> > >> ./mvnw -TC1 -pl :camel-module1,:camel-module2 -Pfastinstall -Psourcecheck > >> > >> Are there any newer IJ instructions or should I set this up myself? > >> > >> Marc > >> > >> (*) http://camel.apache.org/set-up-your-ide.html > >> > >> > >> > >>
