lburgazzoli commented on a change in pull request #595: Set platform as
integration contexts owner
URL: https://github.com/apache/camel-k/pull/595#discussion_r272983820
##########
File path: pkg/controller/integrationcontext/initialize.go
##########
@@ -45,19 +47,24 @@ func (action *initializeAction) CanHandle(ictx
*v1alpha1.IntegrationContext) boo
func (action *initializeAction) Handle(ctx context.Context, ictx
*v1alpha1.IntegrationContext) error {
// The integration platform needs to be initialized before starting to
create contexts
- if _, err := platform.GetCurrentPlatform(ctx, action.client,
ictx.Namespace); err != nil {
+ p, err := platform.GetCurrentPlatform(ctx, action.client,
ictx.Namespace)
+ if err != nil {
Review comment:
wondering if we should chek `p` for `nil` to determine if a platform is
there and use `err` to effectively signalling an error (and the context should
be moved to the error state too)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
