lburgazzoli commented on a change in pull request #45: fix #44 : Support StreamCaching configuration trough a ContextCustomi… URL: https://github.com/apache/camel-k-runtime/pull/45#discussion_r275123523
########## File path: camel-k-runtime-core/src/main/java/org/apache/camel/k/cutomizer/StreamCachingContextCustomizer.java ########## @@ -0,0 +1,124 @@ +package org.apache.camel.k.cutomizer; + +import org.apache.camel.CamelContext; +import org.apache.camel.k.ContextCustomizer; +import org.apache.camel.k.Runtime; +import org.apache.camel.spi.StreamCachingStrategy; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class StreamCachingContextCustomizer implements ContextCustomizer { + private static final Logger LOGGER = LoggerFactory.getLogger(StreamCachingContextCustomizer.class); + + private boolean streamCachingEnabled; + private boolean streamCachingAnySpoolRules; + private int streamCachingBufferSize; + private boolean streamCachingRemoveSpoolDirectoryWhenStopping; + private String streamCachingSpoolChiper; + private String streamCachingSpoolDirectory; + private long streamCachingSpoolThreshold; + private String streamCachingSpoolUsedHeapMemoryLimit; + private int streamCachingSpoolUsedHeapMemoryThreshold; + + public int getStreamCachingBufferSize() { Review comment: maybe we can remove the StreamCaching from methods name so to customize it with properties we do not have duplication like camel.customizer.streamcaching.bufferSize vs camel.cusimizer.streamcaching.streamcaching.streamCachingBufferSize ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services