lburgazzoli commented on a change in pull request #678: A pack of small Knative
improvements
URL: https://github.com/apache/camel-k/pull/678#discussion_r286443225
##########
File path: pkg/trait/knative.go
##########
@@ -101,6 +106,11 @@ func (t *knativeTrait) Configure(e *Environment) (bool,
error) {
t.EndpointSinks = strings.Join(items, ",")
}
+ if t.FilterSourceChannels == nil &&
len(strings.Split(t.ChannelSources, ",")) > 1 {
Review comment:
I think this should be an `or` because in case `FilterSourceChannels` is
`false` but the number of sources is greater than two, then each `from` would
receive a message for every subscribed channel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
