ppalaga edited a comment on issue #22: Initial import cleanup URL: https://github.com/apache/camel-quarkus/pull/22#issuecomment-507559171 > First point is to have the same checkstyle we use in Camel. > Second point the camel contributors can have the same approach they have in main repo. > Third point it reports the violations without fails. So there are no plans to enforce the checkstyle checks by making the CI fail if there are violations? I wonder whether people just not going to ignore the checks altogether? > Harmonizing the behavior in the Camel subproject make the dev experience better. We need to involve the existing community, after the existing community we can focus on new contributors. I do not think this is a valid argument. If in the Camel setup users have to format manually after checkstyle has complained about some violations, with the Quarkus setup, they simply commit the formatted code. They just need to stop caring for the formatting in this repo. They do not need to learn a new process. They just need to forget about the tedious manual steps they needed to perform in Camel. Please do not insist on keeping bad things from Camel main just because they are from Camel main. These small new subprojects are a great opportunity to try and battle test new things that can be eventually brought back to Camel main.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
