ppalaga commented on a change in pull request #121: create extension for camel's core cloud impl URL: https://github.com/apache/camel-quarkus/pull/121#discussion_r312510920
########## File path: extensions/core-cloud/runtime/pom.xml ########## @@ -0,0 +1,57 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.camel.quarkus</groupId> + <artifactId>camel-quarkus-core-cloud-parent</artifactId> + <version>0.1.1-SNAPSHOT</version> + <relativePath>../pom.xml</relativePath> + </parent> + + <artifactId>camel-quarkus-core-cloud</artifactId> Review comment: Why the name `camel-quarkus-core-cloud`? Are we going to have a separate `camel-quarkus-cloud` one day? The current one depends on `camel-cloud` which I assume is a Camel component, so why is this not called simply `camel-quarkus-cloud`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
