astefanutti commented on a change in pull request #922: fix: Add option to
disable Kaniko cache warming
URL: https://github.com/apache/camel-k/pull/922#discussion_r323816673
##########
File path: pkg/controller/integrationplatform/initialize.go
##########
@@ -137,7 +137,7 @@ func (action *initializeAction) Handle(ctx
context.Context, platform *v1alpha1.I
}
// Check if the operator is running in the same namespace
before starting the cache warmer
- if platform.Namespace == platformutil.GetOperatorNamespace() {
+ if platform.Namespace == platformutil.GetOperatorNamespace() &&
platform.Spec.Build.KanikoBuildCache {
Review comment:
Some may find _negative boolean variable_ a bad practice. I'm not sure Cobra
handle boolean pointer so that it is possible to detect the option is not set
and deal with a positive default. If it turns out it's possible, I think it'd
be a better alternative.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
