lburgazzoli commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r326972269
##########
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentConfiguration.groovy
##########
@@ -49,13 +52,15 @@ class ComponentConfiguration {
}
if
(!PropertyBindingSupport.build().withCamelContext(component.camelContext).withTarget(component).withProperty(name,
value).bind()) {
+ LOG.error("Cannot set the component {} property {}",
component.class.getName(), name)
Review comment:
think we do not need to log things if we thrown an exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
