WillemJiang commented on a change in pull request #138: #137 Add the error log
when setting component property failed
URL: https://github.com/apache/camel-k-runtime/pull/138#discussion_r327007650
##########
File path:
camel-k-loader-groovy/src/main/groovy/org/apache/camel/k/loader/groovy/dsl/ComponentsConfiguration.groovy
##########
@@ -48,10 +49,10 @@ class ComponentsConfiguration {
}
if (type.isAssignableFrom(component.class)) {
- callable.resolveStrategy = Closure.DELEGATE_FIRST
+ // Just make sure the closure context is belong to component
+ callable.resolveStrategy = Closure.DELEGATE_ONLY
Review comment:
I tried to throw the PropertyBindingException from the propertyMissing
method, I cannot get the exception when set the Closure.DELEGATE_FIRST. Could
you try to run code yourself?
It looks like Closure.DELEGATE_FIRST just eat up all the exception which is
thrown from ComponentsConfiguration.propertyMissing method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
