davsclaus commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331835287
##########
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##########
@@ -66,7 +66,26 @@ CamelRegistryBuildItem registry(
RuntimeValue<Registry> registry = recorder.createRegistry();
- CamelSupport.services(applicationArchives).forEach(si -> {
+ CamelSupport.services(applicationArchives)
+ .filter(si -> {
+ //
+ // we need to filter out some services for being
registered as some
+ // extension configure them programmatically and if not
properly
+ // configured, they may cause troubles.
+ //
+ // As example, a reactive-executor can be provided by
adding a dep on
+ // camel-reactive-executor-vertx but if that service get
detected and
+ // initialized, it will create an instance of Vert.x
during static init
Review comment:
Its created in doStart lifecycle phase. So I wonder if quarkus-camel is a
bit "wrong" if it starts Camel services during build phase? We should only use
doInit phase IMHO for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
