lburgazzoli commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331846540
##########
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##########
@@ -66,7 +66,26 @@ CamelRegistryBuildItem registry(
RuntimeValue<Registry> registry = recorder.createRegistry();
- CamelSupport.services(applicationArchives).forEach(si -> {
+ CamelSupport.services(applicationArchives)
+ .filter(si -> {
+ //
+ // we need to filter out some services for being
registered as some
+ // extension configure them programmatically and if not
properly
+ // configured, they may cause troubles.
+ //
+ // As example, a reactive-executor can be provided by
adding a dep on
+ // camel-reactive-executor-vertx but if that service get
detected and
+ // initialized, it will create an instance of Vert.x
during static init
Review comment:
Yeah, I need to digg into the camel-reactive-executor-vertx a little bit
more as the camel context is not supposed to be started at build time but only
at runtime init by camel main.
Btw, filtering is still needed as in this case the reactive service is
configured by an extension and what we have in the registry is ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
