ppalaga commented on a change in pull request #231: Add support for quarkus
provided event loop
URL: https://github.com/apache/camel-quarkus/pull/231#discussion_r331883296
##########
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##########
@@ -66,7 +66,22 @@ CamelRegistryBuildItem registry(
RuntimeValue<Registry> registry = recorder.createRegistry();
- CamelSupport.services(applicationArchives).forEach(si -> {
+ CamelSupport.services(applicationArchives)
+ .filter(si -> {
+ //
+ // by default all the service found in
META-INF/service/org/apache/camel are
+ // bound to the registry but some of the services are then
replaced or set
+ // to the camel context directly by extension so it does
not make sense to
+ // instantiate them in this phase.
+ //
+ boolean blacklisted =
si.path.endsWith("reactive-executor") || si.path.endsWith("platform-http");
+ if (blacklisted) {
Review comment:
No problem to accept this for now but it does not look like a sustainable
long term solution. We should find a way for the extensions/components to
blacklist themselves (via BuildItem, or however else). WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
