+1 (binding) Well done Nicola :) Alex
On Mon, Oct 7, 2019 at 12:10 PM Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Ok these issues can be taken care in next release, changing my vote to +1 > (non-binding), anyways I have raised a quick fix for these issues > https://github.com/apache/camel-k/pull/986 > > Regards > Asif > > On 2019/10/07 10:00:26, Andrea Cosentino <anco...@gmail.com> wrote: > > I propose to fix in the next release, this is just a milestone. So lets > > keep the vote open. > > > > Thanks by the way for spotting this. > > > > Il giorno lun 7 ott 2019 alle ore 11:59 Mohammad Asif Siddiqui < > > asifdxtr...@apache.org> ha scritto: > > > > > Here are some more files without ASF header, PMC members can take a > call > > > to rebuild the release or fix it in next release. > > > > > > camel-k-1.0.0-M2/pkg/apis/knative08compat/knative08compat.go > > > camel-k-1.0.0-M2/pkg/client/fastmapper.go > > > camel-k-1.0.0-M2/pkg/util/kubernetes/errors.go > > > > > > Regards > > > Asif > > > > > > On 2019/10/07 09:55:27, Mohammad Asif Siddiqui <asifdxtr...@apache.org > > > > > wrote: > > > > Thanks Nicola for uploading the source artifacts in dev svn, checked > the > > > hashes and signature. > > > > > > > > Sorry I need to change my vote to -1 (non-binding), here are some > issues > > > I found in the source artifacts : > > > > - pkg/client/fastmapper.go doesn't have ASF header > > > > - Unwanted binary in source atrifacts : > > > > > > > > root1@root1-HP-EliteBook-840-G2:~/apache/camel/camel-k-1.0.0-M2/cmd$ > ll > > > > total 20 > > > > drwxr-xr-x 4 root1 root1 4096 Oct 5 15:21 ./ > > > > drwxr-xr-x 13 root1 root1 4096 Oct 5 15:21 ../ > > > > drwxr-xr-x 2 root1 root1 4096 Oct 5 15:21 kamel/ > > > > lrwxrwxrwx 1 root1 root1 70 Oct 5 15:21 manager -> > > > /home/nferraro/gopaths/camel-k/src/github.com/apache/camel-k/cmd/kamel > > > > drwxr-xr-x 3 root1 root1 4096 Oct 5 15:21 util/ > > > > > > > > There is a binary called manager added in the cmd directory which > has a > > > reference to your local env, we should generally not include any > binary in > > > source artifacts. > > > > > > > > Regards Asif > > > > ---------------------------------------------------- > > > > ServiceComb PMC Member, Release Manager > > > > Apache IPMC Member > > > > > > > > > > > > On 2019/10/07 09:40:10, Nicola Ferraro <ni.ferr...@gmail.com> wrote: > > > > > Thanks Mohammad for spotting it, I've now added sources to the > staging > > > repo. > > > > > > > > > > Keys used for signing are in the git repo: > > > > > > > > > https://github.com/apache/camel-k/blob/ee1b8d34961df9553abc7e364e965f00dbbe2bb0/KEYS#L1661-L1715 > > > > > > > > > > Nicola > > > > > > > > > > On Mon, Oct 7, 2019 at 11:24 AM Mohammad Asif Siddiqui < > > > > > asifdxtr...@apache.org> wrote: > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Suggestions : > > > > > > - I cannot find link to KEYS in the voting mail which is used to > > > sign the > > > > > > release artifacts. > > > > > > - Source Artifacts of camel-k 1.0.0-M2 is missing in dev svn > [Major > > > > > > Issue] > > > > > > > > > > > > Regards > > > > > > Asif > > > > > > ---------------------------------------------------- > > > > > > ServiceComb PMC Member, Release Manager > > > > > > Apache IPMC Member > > > > > > > > > > > > > > > > > > On 2019/10/05 10:24:10, Nicola Ferraro <nferr...@apache.org> > wrote: > > > > > > > Hello all: > > > > > > > > > > > > > > This is a combined vote to release Apache Camel K 1.0.0-M2 and > > > Apache > > > > > > Camel > > > > > > > K Runtime 1.0.4. > > > > > > > > > > > > > > Release notes: > > > > > > > > > > https://github.com/apache/camel-k/issues/944#issuecomment-538636280 > > > > > > > > > > > > > > Runtime staging repository: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1156 > > > > > > > Runtime Tag: > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=camel-k-runtime.git;a=shortlog;h=refs/tags/camel-k-runtime-parent-1.0.4 > > > > > > > > > > > > > > Camel K staging repository: > > > > > > > https://dist.apache.org/repos/dist/dev/camel/camel-k/1.0.0-M2/ > > > > > > > Camel K Tag: > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=camel-k.git;a=shortlog;h=refs/tags/1.0.0-M2 > > > > > > > > > > > > > > Staging container image repository: > > > > > > https://hub.docker.com/r/camelk/camel-k > > > > > > > /tags > > > > > > > > > > > > > > It's possible to install all staging artifacts with a single > > > command: > > > > > > > kamel install --operator-image=camelk/camel-k:1.0.0-M2 > > > > > > --maven-repository= > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1156 > > > > > > > > > > > > > > Please test this release candidate and cast your vote. > > > > > > > > > > > > > > [ ] +1 Release the binary as Apache Camel K 1.0.0-M2 and Apache > > > Camel K > > > > > > Runtime > > > > > > > 1.0.4 > > > > > > > [ ] -1 Veto the release (provide specific comments) > > > > > > > > > > > > > > The vote is open for at least 72 hours. > > > > > > > > > > > > > > Thanks, > > > > > > > Nicola Ferraro > > > > > > > > > > > > > > > > > > > > > > > > > > > >
