+1 for formatter-maven-plugin. That's the most painless source
formatting approach I have seen so far. There is no need to do anything,
it just works. They have it in Quarkus [1] and I like it very much.
The drawback of the present non-enforcing approach is that people forget
(my case) about checkstyle, do not know about it or even ignore it
deliberately. Formatting afterwards produces unnecessary clutter in the
git history.
[1]
https://github.com/quarkusio/quarkus/blob/master/build-parent/pom.xml#L238-L246
Thanks,
-- P
On 10/10/2019 12:19, Babak Vahdat wrote:
Thanks John.
Babak
Am 10.10.2019 um 09:26 schrieb John Poth <poth.j...@gmail.com>:
'mvn clean install -Psourcecheck -Dcheckstyle.failOnViolation=true' will
make the build fail on checkstyle errors
On Wed, Oct 9, 2019 at 5:23 PM Andrea Cosentino <anco...@gmail.com> wrote:
Yeah. It would be helpful Guillaume.
Il mer 9 ott 2019, 17:21 Guillaume Nodet <gno...@apache.org> ha scritto:
IIRC, I've seen some projects where a plugin would automatically reformat
the source code if needed, see
https://github.com/revelc/formatter-maven-plugin
That could be a way to help easily / transparently enforcing the rules
...
Le mer. 9 oct. 2019 à 16:55, Andrea Cosentino <anco...@gmail.com> a
écrit
:
This was deliberately done if I remember correctly. It is too strict to
break the build for checkstyle. I don't know what others think about it
Il mer 9 ott 2019, 16:51 Babak Vahdat <babak.vah...@swissonline.ch> ha
scritto:
Hi
AFAIR building Camel source using the sourcecheck Profile enabled
used
to
break the build if there was any Checkstyle issue:
mvn clean install -Psourcecheck
However currently when there’s a Checkstyle issue the build doesn’t
seem
to break for me, instead I see
[INFO] Starting audit...
[ERROR] …
[ERROR] …
[ERROR] …
[ERROR] …
Audit done.
And then the build continues. The result of Checkstyle are then
available
unter the target/checkstyle-result.xml folder of the given Maven
module.
Do you know how one can enforce the build to break as it was the case
before? As otherwise you continuously need to watch the maven log on
console or check target/checkstyle-result.xml for each given module.
Babak
--
------------------------
Guillaume Nodet
