Yeah, I'm fine with that now. Here is my +1. Willem Jiang
Twitter: willemjiang Weibo: 姜宁willem On Mon, Jul 6, 2020 at 2:06 PM James Netherton <jamesnether...@gmail.com> wrote: > > I merged: https://github.com/apache/camel-quarkus/pull/1458. > > Willem - you're now +1 for the release, right? > > > On Mon, 6 Jul 2020 at 03:11, Willem Jiang <willem.ji...@gmail.com> wrote: > > > > Done, I just filled an issue[1] to track it and sent a PR[2] to fix it. > > > > [1]https://github.com/apache/camel-quarkus/pull/1455 > > [2]https://github.com/apache/camel-quarkus/pull/1458 > > > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Sat, Jul 4, 2020 at 2:38 PM Claus Ibsen <claus.ib...@gmail.com> wrote: > > > > > > On Sat, Jul 4, 2020 at 3:55 AM Willem Jiang <willem.ji...@gmail.com> > > > wrote: > > > > > > > > -1. > > > > I just checked the source release package[1], there are some binary > > > > files in the docs/node directory. > > > > I checked the git repo, there is no docs/node directory. > > > > As we are not supposed to ship the binary files in the source kit, so > > > > I vote -1 for this release. > > > > > > > > > > I checked the RC2 and it was also a binary file there. > > > Can you create a JIRA ticket about this so it can be fixed in RC4. > > > > > > Lets this release go ahead - the community wans to get hands on this > > > with the Camel 3.4 upgrade - and they frankly dont care about a node > > > binary file. > > > > > > > > > > > > > [1]https://repository.apache.org/service/local/repositories/orgapachecamel-1224/content/org/apache/camel/quarkus/camel-quarkus/1.0.0-CR3/camel-quarkus-1.0.0-CR3-src.zip > > > > > > > > Willem Jiang > > > > > > > > Twitter: willemjiang > > > > Weibo: 姜宁willem > > > > > > > > On Fri, Jul 3, 2020 at 5:41 PM Peter Palaga <ppal...@redhat.com> wrote: > > > > > > > > > > Hi, > > > > > > > > > > This is a vote to release Apache Camel Quarkus 1.0.0-CR3. > > > > > > > > > > Highlights (same as 1.0.0-CR1): > > > > > * Camel 3.4.0 > > > > > * Quarkus 1.6.0.Final > > > > > * Fixed issues: > > > > > https://github.com/apache/camel-quarkus/milestone/3?closed=1 > > > > > > > > > > Staging repository: > > > > > https://repository.apache.org/content/repositories/orgapachecamel-1224 > > > > > > > > > > > > > > > Tag: > > > > > https://gitbox.apache.org/repos/asf?p=camel-quarkus.git;a=tag;h=e10cfef86e5c3c6670f87a3c1d877f7ebc54e615 > > > > > > > > > > Source release package: > > > > > https://repository.apache.org/service/local/repositories/orgapachecamel-1224/content/org/apache/camel/quarkus/camel-quarkus/1.0.0-CR3/camel-quarkus-1.0.0-CR3-src.zip > > > > > > > > > > Please test this release candidate and cast your vote. > > > > > > > > > > [ ] +1 Release the binary as Apache Camel Quarkus 1.0.0-CR3 > > > > > [ ] -1 Veto the release (provide specific comments) > > > > > > > > > > The vote is open for at least 72 hours. > > > > > > > > > > Many thanks to all contributors! > > > > > > > > > > -- Peter > > > > > > > > > > > > > > > > > -- > > > Claus Ibsen > > > ----------------- > > > http://davsclaus.com @davsclaus > > > Camel in Action 2: https://www.manning.com/ibsen2
