Hi,
It would be great IMO, but I think you need to actually run the tests
for coverage report. We currently skip tests for github PR, because it
takes many hours to test whole codebase - these are running during
nightly build.
Dne 7.10.2020 v 15:08 Djordje Bajić napsal(a):
Hello fellow Cameleers!
I am looking into twitter component, doing some small refactoring. I
noticed something interesting, code coverage is a little above 50%, in my
opinion that is a really poor %. What do you think that we add some checks
or when doing PR reviews to also check coverage of added code? This way we
will promote that tests are mandatory in order to approve PR. Of course
there will be some cases when tests are not available to be written, anyway
i think this will help us reduce the number of bugs and give us freedom to
add, change and refactor with more confidence.
