Thanks Claus! Alright, I will clean it up and send the changes as a PR. Hopefully this helps a bit until the laptop refresh :)
Kind regards On Sat, Feb 6, 2021 at 8:40 AM Claus Ibsen <[email protected]> wrote: > Hi > > Great analysis and work. > > I think the work you have done so far is a big win. > If the next work is only a limited gain then maybe leave it as is. > Maintaining components is also maintaining the unit tests and they are > in some components a "bit harder" when they do something a bit strange > or different than the normal. > > The clustered unit test that runs for 1 min times out on my slow > laptop. Maybe its time for a refresh ;) > > On Fri, Feb 5, 2021 at 3:14 PM Otavio Rodolfo Piske > <[email protected]> wrote: > > > > So, I played a bit with them and found a few things: > > > > 1. On the remote tests, most of the time is consumed on the > > container/infinispan startup (~5 seconds). > > 2. On the remote cluster tests, most of the time is spent on the test > > itself (> 13 secs per test on my desktop) and not on the > > container/infinispan startup (~5 seconds). So it took about a bit more > than > > a minute to run all 3 clustered tests. > > 3. For the remote spring tests, it's the same scenario as #1. > > > > There's a few things we could do to reduce the overall test time for > these, > > but I'd like feedback before going further. > > > > For the remote cluster tests, I reworked them to use JUnit 5 nested > classes > > to organize related tests and use per class lifecycle. With this I could > > reduce the execution time by 25 seconds for this test group: > > - > > > https://github.com/orpiske/camel/blob/infinispan-perf/components/camel-infinispan/camel-infinispan/src/test/java/org/apache/camel/component/infinispan/remote/cluster/AbstractInfinispanRemoteClusteredTest.java > > > > We could try the same strategy to group together other tests in the > remote > > and spring packages and squeeze a few more seconds/minutes of the test > > time. > > > > The downside is that the nested classes - IMHO - may make the code harder > > to read / understand. > > > > Kind regards > > > > On Wed, Feb 3, 2021 at 6:58 PM Otavio Rodolfo Piske < > [email protected]> > > wrote: > > > > > Thanks Claus, > > > > > > It is running slow here as well (~3 min on my desktop). I think it may > be > > > related to the test lifecycle used in the test-infra service for this > one. > > > I'll take a look. > > > > > > Kind regards > > > > > > On Wed, Feb 3, 2021 at 3:52 PM Claus Ibsen <[email protected]> > wrote: > > > > > >> Hi Otavia > > >> > > >> The CI server seems to run those tests < 1 min so they may be quicker > > >> there. > > >> But locally it was taking 5+ min or longer on mine - I breaked the > tests > > >> So it may be slow on my end, but would like to hear from others > > >> > > >> > > >> > > >> > https://ci-builds.apache.org/job/Camel/job/Camel%20JDK11/job/master/523/testReport/ > > >> > > >> > > >> On Wed, Feb 3, 2021 at 3:43 PM Otavio Rodolfo Piske > > >> <[email protected]> wrote: > > >> > > > >> > Hi Claus, > > >> > > > >> > Is this still a problem? If yes, I can try to take a look at them > after > > >> > tomorrow. > > >> > > > >> > Kind regards > > >> > > > >> > On Sun, Jan 31, 2021 at 4:01 PM Claus Ibsen <[email protected]> > > >> wrote: > > >> > > > >> > > Hi > > >> > > > > >> > > I wonder if these tests works correctly. On stop it seems there > is a 1 > > >> > > min timeout failure from infispan server about adding client > > >> > > > > >> > > 2021-01-31 15:56:48,538 [-async-pool-1-2] WARN HOTROD > > >> > > - ISPN004015: Failed adding new server 172.17.0.5:11222 > > >> > > io.netty.channel.ConnectTimeoutException: connection timed out: > > >> > > /172.17.0.5:11222 > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > Claus Ibsen > > >> > > ----------------- > > >> > > http://davsclaus.com @davsclaus > > >> > > Camel in Action 2: https://www.manning.com/ibsen2 > > >> > > > > >> > > > >> > > > >> > -- > > >> > Otavio R. Piske > > >> > http://orpiske.net > > >> > > >> > > >> > > >> -- > > >> Claus Ibsen > > >> ----------------- > > >> http://davsclaus.com @davsclaus > > >> Camel in Action 2: https://www.manning.com/ibsen2 > > >> > > > > > > > > > -- > > > Otavio R. Piske > > > http://orpiske.net > > > > > > > > > -- > > Otavio R. Piske > > http://orpiske.net > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 > -- Otavio R. Piske http://orpiske.net
