On Tue, Feb 9, 2021 at 11:45 AM Gregor Zurowski
<gre...@list.zurowski.org> wrote:
>
> Thanks Claus. Just for future reference, how do we check for
> formatting issues on the jbpm component?
>
This component was special it copied over its source to a folder in
target that happened before those other plugins does it sorting, and
so it "was not correct".
That step was not needed.
The component have some special bpm files in src/main/resources, that
needs to be updated with the ${project.version} by maven. And I fixed
it by only doing that.
Then the java source is just like all the other components.
> On Tue, Feb 9, 2021 at 11:41 AM Claus Ibsen <claus.ib...@gmail.com> wrote:
> >
> > Hi Gregor
> >
> > I have just pushed a fix to the master branch.
> >
> > You are welcome to try again, thanks.
> >
> > On Tue, Feb 9, 2021 at 11:35 AM Claus Ibsen <claus.ib...@gmail.com> wrote:
> > >
> > > Hi
> > >
> > > Ah the jbmp component is special, I am working on fixing this. I will
> > > report back.
> > >
> > > On Tue, Feb 9, 2021 at 11:32 AM Gregor Zurowski
> > > <gre...@list.zurowski.org> wrote:
> > > >
> > > > I already tried that, but running these commands on
> > > > `components/camel-jbpm` will not yield any errors:
> > > >
> > > > ```
> > > > cd components/camel-jbpm
> > > > rm -rf src/generated
> > > > mvn clean install -Pfastinstall
> > > > mvn clean install -Psourcecheck
> > > > ```
> > > >
> > > > Both checkstyle and impsort plugins pass as normal. It seems there is
> > > > a misalignment between the normal build and a release build in terms
> > > > of the impsort plugin.
> > > >
> > > > Thanks,
> > > > Gregor
> > > >
> > > > On Tue, Feb 9, 2021 at 11:25 AM Claus Ibsen <claus.ib...@gmail.com>
> > > > wrote:
> > > > >
> > > > > Hi
> > > > >
> > > > > I usually run
> > > > >
> > > > > mvn clean install -P fastinstall
> > > > >
> > > > > And then the formatter and imp sorter will do its work
> > > > > And after that you can check CS
> > > > >
> > > > > And if there is some problems with the source generated files you can
> > > > > do first (before the step above)
> > > > > rm -rf src/generated
> > > > >
> > > > > mvn compile -P sourcecheck
> > > > >
> > > > > And then commit the changed files.
> > > > >
> > > > >
> > > > > On Tue, Feb 9, 2021 at 11:20 AM Gregor Zurowski
> > > > > <gre...@list.zurowski.org> wrote:
> > > > > >
> > > > > > Hi Everyone:
> > > > > >
> > > > > > I am having issues related to code formatting while preparing the
> > > > > > release. The impsort Maven plugin was first giving me the following
> > > > > > error:
> > > > > >
> > > > > > ```
> > > > > > [ERROR] Failed to execute goal
> > > > > > net.revelc.code:impsort-maven-plugin:1.5.0:check (check) on project
> > > > > > camel-jbpm: Imports are not sorted in
> > > > > > /git/camel/components/camel-jbpm/target/generated-sources/java/org/apache/camel/component/jbpm/JBPMEndpoint.java
> > > > > > ```
> > > > > >
> > > > > > I was able to address this with
> > > > > > https://github.com/apache/camel/commit/bba953fc9a8378a70bcc123ef96a0f4dd0ab09b5.
> > > > > >
> > > > > > Now I am getting an error about the order of imports:
> > > > > >
> > > > > > ```
> > > > > > [ERROR] Failed to execute goal
> > > > > > net.revelc.code:impsort-maven-plugin:1.5.0:check (check) on project
> > > > > > camel-jbpm: Imports are not sorted in
> > > > > > /git/camel/components/camel-jbpm/target/generated-sources/java/org/apache/camel/component/jbpm/JBPMEndpoint.java
> > > > > > ```
> > > > > >
> > > > > > I would like to be able to fix those issues without guessing, but a
> > > > > > normal `mvn clean install` on `components/camel-jbpm` will not yield
> > > > > > any errors. Do you know how to address this?
> > > > > >
> > > > > > Thanks in advance,
> > > > > > Gregor
> > > > > >
> > > > > > On Tue, Feb 9, 2021 at 7:07 AM Claus Ibsen <claus.ib...@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > Hi Gregor
> > > > > > >
> > > > > > > Oh yeah that is a problem.
> > > > > > >
> > > > > > > I think I have fixed it, can you try again with the latest code.
> > > > > > >
> > > > > > > On Mon, Feb 8, 2021 at 9:56 PM Gregor Zurowski
> > > > > > > <gre...@list.zurowski.org> wrote:
> > > > > > > >
> > > > > > > > Quickly tested the master branch, but getting the following
> > > > > > > > error on
> > > > > > > > `build:prepare`:
> > > > > > > >
> > > > > > > > ```
> > > > > > > > [ERROR] Failed to execute goal on project
> > > > > > > > camel-infinispan-embedded:
> > > > > > > > Could not resolve dependencies for project
> > > > > > > > org.apache.camel:camel-infinispan-embedded:jar:3.8.0-SNAPSHOT:
> > > > > > > > Could
> > > > > > > > not find artifact
> > > > > > > > org.apache.camel:camel-infinispan-common:jar:tests:3.8.0-SNAPSHOT
> > > > > > > > in
> > > > > > > > apache.snapshots (https://repository.apache.org/snapshots/) ->
> > > > > > > > [Help
> > > > > > > > 1]
> > > > > > > > ```
> > > > > > > >
> > > > > > > > Haven't looked any further, will revisit this tomorrow morning.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Gregor
> > > > > > > >
> > > > > > > > On Mon, Feb 8, 2021 at 7:42 PM Gregor Zurowski
> > > > > > > > <gre...@list.zurowski.org> wrote:
> > > > > > > > >
> > > > > > > > > OK, I will start with the release now.
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Gregor
> > > > > > > > >
> > > > > > > > > On Mon, Feb 8, 2021 at 7:20 PM Claus Ibsen
> > > > > > > > > <claus.ib...@gmail.com> wrote:
> > > > > > > > > >
> > > > > > > > > > Hi
> > > > > > > > > >
> > > > > > > > > > Okay the CXF and Jetty upgrade is complete.
> > > > > > > > > >
> > > > > > > > > > The branch is ready for cutting the release.
> > > > > > > > > >
> > > > > > > > > > On Mon, Feb 8, 2021 at 6:46 PM Claus Ibsen
> > > > > > > > > > <claus.ib...@gmail.com> wrote:
> > > > > > > > > > >
> > > > > > > > > > > Hi
> > > > > > > > > > >
> > > > > > > > > > > I am just testing upgrades of Jetty and CXF to latest
> > > > > > > > > > > release, as it
> > > > > > > > > > > would be good to be on latest of those, as they can have
> > > > > > > > > > > CVE fixes and
> > > > > > > > > > > whatnot.
> > > > > > > > > > >
> > > > > > > > > > > On Mon, Feb 8, 2021 at 6:30 PM Jeremy Ross
> > > > > > > > > > > <jeremy.g.r...@gmail.com> wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > Just ran tests on the latest build and it seems to have
> > > > > > > > > > > > resolved.
> > > > > > > > > > > >
> > > > > > > > > > > > On Mon, Feb 8, 2021 at 10:52 AM Gregor Zurowski
> > > > > > > > > > > > <gre...@list.zurowski.org>
> > > > > > > > > > > > wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > > Is that still blocking us from releasing?
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Mon, Feb 8, 2021 at 2:37 PM Zoran Regvart
> > > > > > > > > > > > > <zo...@regvart.com> wrote:
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Hi Claus,
> > > > > > > > > > > > > > should we worry about this:
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > https://camel.zulipchat.com/#narrow/stream/257298-camel/topic/Problem.20with.20nightlies
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > raised by Jeremy. I know it takes a special setup
> > > > > > > > > > > > > > to run the
> > > > > > > > > > > > > > Salesforce integration tests, I'll double check
> > > > > > > > > > > > > > that on my end.
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > zoran
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On Fri, Jan 22, 2021 at 4:57 PM Claus Ibsen
> > > > > > > > > > > > > > <claus.ib...@gmail.com>
> > > > > > > > > > > > > wrote:
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Hi
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > It would be good to get Camel 3.8 out before mid
> > > > > > > > > > > > > > > February.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > There is already a bunch of work since 3.7, and
> > > > > > > > > > > > > > > its good to get this
> > > > > > > > > > > > > > > into the hands of the community.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > There are a number of tickets assigned to 3.8,
> > > > > > > > > > > > > > > but if you know that
> > > > > > > > > > > > > > > you wont get time to work on it, then you are
> > > > > > > > > > > > > > > welcome to move to 3.9.
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > Claus Ibsen
> > > > > > > > > > > > > > > -----------------
> > > > > > > > > > > > > > > http://davsclaus.com @davsclaus
> > > > > > > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > --
> > > > > > > > > > > > > > Zoran Regvart
> > > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Claus Ibsen
> > > > > > > > > > > -----------------
> > > > > > > > > > > http://davsclaus.com @davsclaus
> > > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Claus Ibsen
> > > > > > > > > > -----------------
> > > > > > > > > > http://davsclaus.com @davsclaus
> > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Claus Ibsen
> > > > > > > -----------------
> > > > > > > http://davsclaus.com @davsclaus
> > > > > > > Camel in Action 2: https://www.manning.com/ibsen2
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Claus Ibsen
> > > > > -----------------
> > > > > http://davsclaus.com @davsclaus
> > > > > Camel in Action 2: https://www.manning.com/ibsen2
> > >
> > >
> > >
> > > --
> > > Claus Ibsen
> > > -----------------
> > > http://davsclaus.com @davsclaus
> > > Camel in Action 2: https://www.manning.com/ibsen2
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > http://davsclaus.com @davsclaus
> > Camel in Action 2: https://www.manning.com/ibsen2
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
