I agree with Claus, As the "issue" is there for a while, we can just let Camel 3.4.6 release running and fix for next "major" one.
If Gregor wants to recut, I don’t have problem, but not "blocker" IMHO. Regards JB > Le 16 juin 2021 à 10:51, Claus Ibsen <claus.ib...@gmail.com> a écrit : > > On Wed, Jun 16, 2021 at 10:42 AM Zoran Regvart <zo...@regvart.com > <mailto:zo...@regvart.com>> wrote: >> >> Hi Gregor, >> It seems that the change I made[1] to exclude the `docs/node` >> directory from the source assembly did not help. The `docs/node` is >> still present in the zip file[2]. >> > > Can't we just fix it for 3.7.x onwards. This is the last 3.4.x release > and its very time consuming to redo releases. > And end user don't care, its not a critical bug in camel-core. > > >> I should have tested this better. I'm afraid that this is -1 from me. >> Let me work on a fix, I think we need to re-release. >> >> zoran >> >> [1] >> https://github.com/apache/camel/commit/64fb0e08aef39e07c08cbf3150939325cf723e05 >> [2] >> https://repository.apache.org/content/repositories/orgapachecamel-1327/org/apache/camel/apache-camel/3.4.6/apache-camel-3.4.6-src.zip >> >> On Mon, Jun 14, 2021 at 12:31 PM Gregor Zurowski >> <gre...@list.zurowski.org> wrote: >>> >>> Hi Everyone: >>> >>> This is a vote to release Apache Camel 3.4.6, a new patch release for >>> the 3.4.x LTS branch with 8 improvements and fixes. >>> >>> Release notes: >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349520&projectId=12311211 >>> >>> == Apache Camel 3.4.6 == >>> >>> Staging repository: >>> https://repository.apache.org/content/repositories/orgapachecamel-1327/ >>> >>> Tarballs: >>> https://repository.apache.org/content/repositories/orgapachecamel-1327/org/apache/camel/apache-camel/3.4.6/ >>> >>> Tag: >>> https://gitbox.apache.org/repos/asf?p=camel.git;a=tag;h=refs/tags/camel-3.4.6 >>> >>> == Apache Camel Spring Boot 3.4.6 == >>> >>> Staging repository: >>> https://repository.apache.org/content/repositories/orgapachecamel-1330/ >>> >>> Tag: >>> https://gitbox.apache.org/repos/asf?p=camel-spring-boot.git;a=tag;h=refs/tags/camel-spring-boot-3.4.6 >>> >>> == Apache Camel Karaf 3.4.6 == >>> >>> Staging repository: >>> https://repository.apache.org/content/repositories/orgapachecamel-1331/ >>> >>> Tag: >>> https://gitbox.apache.org/repos/asf?p=camel-karaf.git;a=tag;h=refs/tags/camel-karaf-3.4.6 >>> >>> Please test this release candidate and cast your vote. >>> [ ] +1 Release the binary as Apache Camel, Camel Spring Boot and Camel >>> Karaf 3.4.6 >>> [ ] -1 Veto the release (provide specific comments) >>> >>> The vote is open for at least 72 hours. >>> >>> Thanks, >>> Gregor >> >> >> >> -- >> Zoran Regvart > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com <http://davsclaus.com/> @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2 > <https://www.manning.com/ibsen2>
