Even worse,

commit 8101887dc03352442f308358246409e425a9e441
Author: nicolaferraro <[email protected]>
Date:   Wed Jan 12 13:50:25 2022 +0100

    Add KEDA markers to some Kamelets

 docs/modules/ROOT/assets/images/kamelets/delay-action.svg |   1 -
 docs/modules/ROOT/nav.adoc                                | 157 
+------------------------------------------------------------------------------------------------------------------------------------------------------------
 docs/modules/ROOT/pages/delay-action.adoc                 | 160 
----------------------------------------------------------------------------------------------------------------------------------------------------------------
 docs/{modules/ROOT => }/pages/index.adoc                  |   0
 4 files changed, 1 insertion(+), 317 deletions(-)

completely removed the next kamelet docs.

Please pay attention to what you are doing to the docs!

David Jencks

> On Jan 12, 2022, at 6:56 PM, David Jencks <[email protected]> wrote:
> 
> Today the website build is broken due to:
> 
> commit 4e15b691d47ed8c2aff86c4a08eb0b783f50d636
> Author: Antonin Stefanutti <[email protected] 
> <mailto:[email protected]>>
> Date:   Wed Jan 12 11:33:37 2022 +0100
> 
>     feat: Add HTTP proxy documentation
> 
> 
> As detailed here:
> 
> https://camel.apache.org/manual/improving-the-documentation.html#_quick_partial_build
>  
> <https://camel.apache.org/manual/improving-the-documentation.html#_quick_partial_build>
> 
> once you are set up, it is quick and easy to do a partial local build of your 
> changes.
> 
> Admittedly I’m familiar with this, but it took me about 2 minutes to run the 
> local build, fix the problem, rerun the local build, and make 
> https://github.com/apache/camel-k/pull/2874 
> <https://github.com/apache/camel-k/pull/2874>.
> 
> Please don’t break everything for everyone else by committing doc changes 
> without verifying that they work.
> 
> If you have problems setting this up, please let me know what they are rather 
> than ignoring the possibility of stopping everyone else from working on docs.
> 
> It would be great to eventually have a PR check for doc changes, and it might 
> be within reach, but it involves some communication between repos and GitHub 
> workflows, so it’s not trivial to set up.
> 
> Would you commit java or go code that doesn’t compile?  Don’t commit AsciiDoc 
> that doesn’t compile either.
> 
> Thanks
> David Jencks

Reply via email to