Backport for sure. -- Andrea Cosentino ---------------------------------- Apache Camel PMC Chair Apache Karaf Committer Apache Servicemix PMC Member Email: ancosen1...@yahoo.com Twitter: @oscerd2 Github: oscerd
On Wednesday, March 23, 2022, 11:06:59 AM GMT+1, Gregor Zurowski <gre...@list.zurowski.org> wrote: Should I keep my changes for the testcontainers removal local (https://github.com/apache/camel-spring-boot/commit/dc45a6a0267effce166f1c5edb23ee93505147e5) to the 3.16.x branch or should I backport it into main? Thanks, Gregor On Wed, Mar 23, 2022 at 10:44 AM Claus Ibsen <claus.ib...@gmail.com> wrote: > > Hi Gregor > > Ah thanks yeah so on camel spring boot, we have contributors working > on adding more tests to improve the QA of this project. > And as such we hit these problems, but we have learned now and 3.17 > should be an easier release. > > > On Wed, Mar 23, 2022 at 9:35 AM Gregor Zurowski > <gre...@list.zurowski.org> wrote: > > > > Thank you, Claus. I got a bit further but ran into the next issue: > > > > ``` > > [ERROR] Failed to execute goal on project camel-consul-starter: Could > > not resolve dependencies for project > > org.apache.camel.springboot:camel-consul-starter:jar:3.16.0: Could not > > find artifact org.apache.camel:camel-testcontainers:jar:3.16.0 in > > central (https://repo.maven.apache.org/maven2) -> [Help 1] > > ``` > > > > The Consul starter depends on camel-testcontainers, but we had removed > > it recently with > > https://github.com/apache/camel/commit/51d91b5e974e0b5753313c8a21610fc14cc89379. > > > > I have fixed the issue by removing the test-containers dependency and > > the corresponding test: > > https://github.com/apache/camel-spring-boot/commit/dc45a6a0267effce166f1c5edb23ee93505147e5 > > > > Thanks, > > Gregor > > > > > > On Tue, Mar 22, 2022 at 10:36 PM Claus Ibsen <claus.ib...@gmail.com> wrote: > > > > > > Hi > > > > > > Okay so I have fixed this on main branch and a PR with the set of > > > commits to fix this which can be merged on the 3.16.0 branch you use > > > for the release > > > https://github.com/apache/camel-spring-boot/pull/479 > > > > > > On Tue, Mar 22, 2022 at 10:06 PM Claus Ibsen <claus.ib...@gmail.com> > > > wrote: > > > > > > > > Hi > > > > > > > > Okay so its related to all the tests added to the -starter JARs where > > > > they have added test dependencies, but it seems this requires to add > > > > <version> so it can pickup the correct Camel version. > > > > > > > > > > > > > > > > <groupId>org.apache.camel</groupId> > > > > <artifactId>camel-test-spring-junit5</artifactId> > > > > + <version>${camel-version}</version> > > > > > > > > > > > > On Tue, Mar 22, 2022 at 10:03 PM Claus Ibsen <claus.ib...@gmail.com> > > > > wrote: > > > > > > > > > > Hi > > > > > > > > > > Okay got a step further > > > > > > > > > > [ERROR] > > > > > org.apache.camel:camel-test-spring-junit5:jar:3.16.0-SNAPSHOT:test > > > > > [ERROR] in project 'Camel SB Starters :: Avro' > > > > > (org.apache.camel.springboot:camel-avro-starter:jar:3.16.0-SNAPSHOT) > > > > > > > > > > On Tue, Mar 22, 2022 at 9:14 PM Claus Ibsen <claus.ib...@gmail.com> > > > > > wrote: > > > > > > > > > > > > Hi > > > > > > > > > > > > If I try to run the dry run prepare for the release tag on CSB I > > > > > > can see > > > > > > > > > > > > [ERROR] Failed to execute goal > > > > > > org.apache.maven.plugins:maven-release-plugin:2.4.2:prepare > > > > > > (default-cli) on project spring-boot: Can't release project due to > > > > > > non > > > > > > released dependencies : > > > > > > [ERROR] > > > > > > org.apache.camel:bom-generator-maven-plugin:jar:3.16.0-SNAPSHOT:compile > > > > > > [ERROR] > > > > > > org.apache.camel:camel-package-maven-plugin:jar:3.16.0-SNAPSHOT:compile > > > > > > [ERROR] > > > > > > org.apache.camel:camel-tooling-model:jar:3.16.0-SNAPSHOT:compile > > > > > > [ERROR] > > > > > > org.apache.camel:camel-tooling-util:jar:3.16.0-SNAPSHOT:compile > > > > > > [ERROR] > > > > > > org.apache.camel:camel-util-json:jar:3.16.0-SNAPSHOT:compile > > > > > > [ERROR] > > > > > > org.apache.camel:spi-annotations:jar:3.16.0-SNAPSHOT:compile > > > > > > [ERROR] in project 'Camel SB Tooling :: Generator Maven Plugin' > > > > > > (org.apache.camel.springboot:camel-spring-boot-generator-maven-plugin:maven-plugin:3.16.0-SNAPSHOT) > > > > > > [ERROR] -> [Help 1] > > > > > > > > > > > > > > > > > > On Tue, Mar 22, 2022 at 7:58 PM Andrea Cosentino > > > > > > <anco...@gmail.com> wrote: > > > > > > > > > > > > > > What are the deps with snapshot? > > > > > > > > > > > > > > Il mar 22 mar 2022, 19:35 Gregor Zurowski > > > > > > > <gre...@list.zurowski.org> ha > > > > > > > scritto: > > > > > > > > > > > > > > > I am having another problem when preparing camel-spring-boot. > > > > > > > > There > > > > > > > > are dependencies with snapshot versions in > > > > > > > > `tooling/camel-spring-boot-dependencies/pom.xml` and I vaguely > > > > > > > > recall > > > > > > > > we went through this before... Claus, do you remember this? > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Gregor > > > > > > > > > > > > > > > > On Sun, Mar 20, 2022 at 12:09 PM Claus Ibsen > > > > > > > > <claus.ib...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hi Gregor > > > > > > > > > > > > > > > > > > The branches are ready for cutting the release. > > > > > > > > > I have done a RAT check and fixed the few files that were > > > > > > > > > missing > > > > > > > > > license headers. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 14, 2022 at 11:44 AM Gregor Zurowski > > > > > > > > > <gre...@list.zurowski.org> wrote: > > > > > > > > > > > > > > > > > > > > Hi Everyone: > > > > > > > > > > > > > > > > > > > > I tried building the 3.16.0 release yesterday but struggled > > > > > > > > > > with a > > > > > > > > > > slow and spotty internet connection (at a hotel) and > > > > > > > > > > several code > > > > > > > > > > formatting issues on each attempt. Unfortunately I won't be > > > > > > > > > > able to > > > > > > > > > > take care of this before next Monday. Is that OK with > > > > > > > > > > everyone? > > > > > > > > > > > > > > > > > > > > Thanks in advance, > > > > > > > > > > Gregor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sat, Mar 12, 2022 at 1:15 AM Claus Ibsen > > > > > > > > > > <claus.ib...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > On Thu, Mar 10, 2022 at 5:47 PM Gregor Zurowski > > > > > > > > > > > <gre...@list.zurowski.org> wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hi Claus, > > > > > > > > > > > > > > > > > > > > > > > > I am traveling all day tomorrow, but I can start the > > > > > > > > > > > > release on > > > > > > > > Saturday/Sunday. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks Gregor > > > > > > > > > > > > > > > > > > > > > > The branch is ready for cutting the release. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Gregor > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Mar 10, 2022 at 3:51 PM Claus Ibsen > > > > > > > > > > > > <claus.ib...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > > > > > > > > > > > > > We are polishing up the last bits today. > > > > > > > > > > > > > I think we will be ready tomorrow so Gregor can cut > > > > > > > > > > > > > the release > > > > > > > > when > > > > > > > > > > > > > he has time. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 7, 2022 at 1:30 PM Claus Ibsen < > > > > > > > > claus.ib...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > > > > > > > > > > > > > > > We have a lot of stuff going into 3.16.0 already, > > > > > > > > > > > > > > so I think > > > > > > > > it would > > > > > > > > > > > > > > be good to close down and get the last bits done, > > > > > > > > > > > > > > and then cut > > > > > > > > a > > > > > > > > > > > > > > release on thursday/friday or over the weekend? > > > > > > > > > > > > > > > > > > > > > > > > > > > > If I get some clear time then I would work on > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/CAMEL-16834 > > > > > > > > > > > > > > > > > > > > > > > > > > > > Which is a bigger work but is important to have a > > > > > > > > > > > > > > common error > > > > > > > > handler > > > > > > > > > > > > > > model in the core DSL so it's standard in all DSLs > > > > > > > > > > > > > > and we dont > > > > > > > > have > > > > > > > > > > > > > > custom code for yaml, xml, java etc. > > > > > > > > > > > > > > > > > > > > > > > > > > > > However it does require a few days of many hours of > > > > > > > > uninterrupted work > > > > > > > > > > > > > > to get around all of the needed changes. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Otavio, is there more work needed for the resumable > > > > > > > > > > > > > > EIP ? > > > > > > > > > > > > > > > > > > > > > > > > > > > > For tickets with 3.16.0 as target then it would be > > > > > > > > > > > > > > good to move > > > > > > > > > > > > > > tickets to 3.17.0 that you know that you will not > > > > > > > > > > > > > > implement > > > > > > > > this week. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > Claus Ibsen > > > > > > > > > > > > > > ----------------- > > > > > > > > > > > > > > http://davsclaus.com @davsclaus > > > > > > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > Claus Ibsen > > > > > > > > > > > > > ----------------- > > > > > > > > > > > > > http://davsclaus.com @davsclaus > > > > > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > Claus Ibsen > > > > > > > > > > > ----------------- > > > > > > > > > > > http://davsclaus.com @davsclaus > > > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Claus Ibsen > > > > > > > > > ----------------- > > > > > > > > > http://davsclaus.com @davsclaus > > > > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Claus Ibsen > > > > > > ----------------- > > > > > > http://davsclaus.com @davsclaus > > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > > > > > -- > > > > > Claus Ibsen > > > > > ----------------- > > > > > http://davsclaus.com @davsclaus > > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > > > > > -- > > > > Claus Ibsen > > > > ----------------- > > > > http://davsclaus.com @davsclaus > > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > > > > > > > > > -- > > > Claus Ibsen > > > ----------------- > > > http://davsclaus.com @davsclaus > > > Camel in Action 2: https://www.manning.com/ibsen2 > > > > -- > Claus Ibsen > ----------------- > http://davsclaus.com @davsclaus > Camel in Action 2: https://www.manning.com/ibsen2
