luigidemasi commented on code in PR #119:
URL: https://github.com/apache/camel-kit/pull/119#discussion_r4361544531
##########
camel-kit-core/src/test/java/io/github/luigidemasi/camelkit/generator/ResourceConsistencyTest.java:
##########
@@ -937,13 +939,13 @@ void
catalogAndExecutionIngressRequireValidatedBindingsInsteadOfSummaryTrust() t
"Every MCP-summary consumer or subagent must inherit
context authority");
}
assertContainsAll(catalogResearcher,
- "camel_catalog_components(limit=0)",
"camel_catalog_component_maven(component, runtime,
platformBom)",
"`camel_catalog_components`, `camel_catalog_eips`",
"`camel_catalog_dataformats`, or `camel_catalog_languages`",
"A detail-call error is `UNVERIFIED`, not authoritative
absence",
"Use `INVALID_BINDING`, never `VERIFIED`",
"`NOT_FOUND` requires a successful, complete matching list
result with no exact artifact name",
+ "source=.camel-kit/config.properties",
Review Comment:
**Required (P2): add a regression guard for the removed probe instructions.**
This assertion checks the new researcher binding text, but the old
requirement can still return elsewhere unnoticed: restoring `probe resolved
camelVersion once per batch` in the migration diagram leaves all 29 consistency
tests and all nine structural tests green.
Extend the existing stale-contract scan or add a focused test covering the
active guides and personas, including the migration diagram, researcher output
and shared rules. Demonstrate failure when the old instruction is restored and
success with the corrected resources. This regression-test code change is
required before merge, as requested in the previous review.
##########
CHANGELOG.md:
##########
@@ -24,6 +24,12 @@ and this project adheres to [Semantic
Versioning](https://semver.org/spec/v2.0.0
Legacy `.claude/commands/camel-*.md` stubs are cleaned up on regeneration;
user-created commands are preserved.
Internal skills (`camel-design`, `camel-implement`, `camel-test`,
`camel-verify`) are hidden from both user
invocation and model auto-selection. Doctor accepts legacy
`.claude/commands` workspaces.
+- **Teach knowledge server niche and drop `limit=0` probe (#108)** — add a `##
Camel Knowledge MCP Server` section
+ to `shared/mcp-setup.md` documenting when to use `camel-knowledge` vs
`camel` catalog, with the server-name rule
+ and tool list. Rewrite Rule 3 and Iron Law 1 steps 2–3 to bind the catalog
version from
+ `.camel-kit/config.properties` instead of the broken
`camel_catalog_components(limit=0)` probe. Remove all
+ `limit=0` probe references from downstream guides and agent personas. Add
forward-compatibility notes for
+ Camel 4.23+ tool renames (`camel_catalog_find` / `camel_catalog_doc`).
Review Comment:
**Required (P3): remove the claim about the deleted 4.23 notes.**
The new commit removes both forward-compatibility notes, so this sentence
now advertises guidance that is absent from the shipped resources. Delete the
final sentence. Also remove the same claim from the PR summary and correct the
test-plan statement that there are no Java changes.
This documentation correction is required in this PR before merge,
regardless of its lower priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
