Hi Xuchuanyin

The idea you have mentioned is good and correct. But I feel that the current
implementation behavior is better because of the following reasons.

1.  Code understanding will be good as per the current implementation.
Looking at the thrift anyone can understand the design and come to know that
it has a boolean flag to say whether min max is stored for a particular
column. This will be even helpful for Carbon CLI tool where we can display
whether min max for a column is stored or not without comparing the min and
max values for all columns with FAKE data.
2. It is difficult to decide on the FAKE value. Any value which we decide as
the FAKE value will become a data limitation. In the near future we will be
extending this feature support for binary type also.
3. The comparison of a boolean flag will be much faster as compared to FAKE
value byte comparison.
4. The memory space required for storing boolean flag will be negligible as
we are already saving the space when the specified byte limit is reached by
storing 0 length byte as min and max.

Regards
Manish Gupta



--
Sent from: 
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Reply via email to