I think there are other places that are using apache-common-log, like https://github.com/apache/carbondata/blob/382ce430a18ca3d7d0b444777c66591e2c2e705f/hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java#L103
Since this is not introduced in this version, I think it is OK to raise a jira now and solve it in next version. So +1 for the voting. Regards, Jacky > 在 2018年12月1日，下午9:41，xuchuanyin <xuchuan...@hust.edu.cn> 写道： > > Hi, please consider this line of code: > https://github.com/apache/carbondata/blob/master/core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java#L78 > > It uses apache-common-log directly instead of carbondata log. I’m not sure > about the impact of this. > Please take care of this before voting. > > Sent from laptop > > From: Ravindra Pesala > Sent: Saturday, December 1, 2018 08:58 > To: dev > Subject: [VOTE] Apache CarbonData 1.5.1(RC2) release > > Hi > > I submit the Apache CarbonData 1.5.1 (RC2) for your vote. > > 1.Release Notes: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320220&version=12344320 > > > Some key features and improvements in this release: > > 1. Optimized scan performance by avoiding multiple data copies and > avoided double filtering for spark fileformat and presto by lazy loading > and page pruning. > 2. Supported customize column compressor > 3. Supported concurrent reading through SDK reader to improve read > performance. > 4. Supported fallback mechanism when offheap memory is not enough then > switch to onheap > 5. Supported C++ interface for writing carbon data in CSDK > 6. Supported VectorizedReader for SDK Reader to improve read performance. > 7. Improved Blocklet DataMap pruning in driver using multi-threading. > 8. Make inverted index false by default > 9. Enable Local dictionary by default > 10. Support prefetch for compaction to improve compaction performance. > 11. Many Bug fixes and stabilized Carbondata. > > > 2. The tag to be voted upon : apache-carbondata-1.5.1-rc2 (commit: > 1d1eb7bd625f1af1745c555274dd69298a79ab65) > https://github.com/apache/carbondata/releases/tag/apache-carbondata-1.5.1-rc2 > > > 3. The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/carbondata/1.5.1-rc2/ > > > 4. A staged Maven repository is available for review at: > https://repository.apache.org/content/repositories/orgapachecarbondata-1036/ > > > 5. Release artifacts are signed with the following key: > > *https://people.apache.org/keys/committer/ravipesala.asc > <https://link.getmailspring.com/link/1524823736.local-38e60b2f-d8f4-v1.2.1-7e744...@getmailspring.com/9?redirect=https%3A%2F%2Fpeople.apache.org%2Fkeys%2Fcommitter%2Fravipesala.asc&recipient=ZGV2QGNhcmJvbmRhdGEuYXBhY2hlLm9yZw%3D%3D>* > > > Please vote on releasing this package as Apache CarbonData 1.5.1, The vote > > will be open for the next 72 hours and passes if a majority of > > at least three +1 PMC votes are cast. > > > [ ] +1 Release this package as Apache CarbonData 1.5.1 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > Regards, > Ravindra. > > >
